From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757560AbcG0Shq (ORCPT ); Wed, 27 Jul 2016 14:37:46 -0400 Received: from mail-co1nam03on0060.outbound.protection.outlook.com ([104.47.40.60]:11266 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753179AbcG0Shk (ORCPT ); Wed, 27 Jul 2016 14:37:40 -0400 Authentication-Results: spf=fail (sender IP is 66.35.236.227) smtp.mailfrom=opensource.altera.com; arm.com; dkim=pass (signature was verified) header.d=altera.onmicrosoft.com;arm.com; dmarc=none action=none header.from=opensource.altera.com; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=tthayer@opensource.altera.com; Reply-To: Subject: Re: [PATCH 05/10] EDAC, altera: Add Arria10 NAND EDAC support References: <1468512408-5156-1-git-send-email-tthayer@opensource.altera.com> <1468512408-5156-6-git-send-email-tthayer@opensource.altera.com> <20160727171035.GA23851@nazgul.tnic> To: Borislav Petkov CC: , , , , , , , , , , , , , , , From: Thor Thayer Message-ID: <579900B8.3020502@opensource.altera.com> Date: Wed, 27 Jul 2016 13:43:04 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160727171035.GA23851@nazgul.tnic> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: SN2PR80CA035.lamprd80.prod.outlook.com (10.141.39.173) To BN3PR03MB1480.namprd03.prod.outlook.com (10.163.35.143) X-MS-Office365-Filtering-Correlation-Id: 9b375f4a-5d6c-4bb9-58ad-08d3b64d152e X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1480;2:efddy2TvXfPCjK2ZF7mX5mRHukVYfywwC4THzKvQY7hCitakkpPlGHjGTmnRalpTGnLAnsLGOPyQNunyU7SsIxFcPv0Pxks8zB03EApWQAy8wVUa0b0pT6r2cvwufON/OOwz9yL0F7toPuG9IE7mS1Zw7nBTXj0n3MExyZIKEErYLsG8zJc8Sk0rs8IvYCsS;3:nnKbchwme+ZBVhYVWFCc4DJhBj2iDSHefuFCc4ay0XnFufDyq731+HJo8BsYcuizENRsvP/FPMQTb6ReD1BZveMQVZdsKP8W3ps6YSbArOCoZXW7f8kAv8Gz/LAIXEfU X-Microsoft-Antispam-Untrusted: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1480; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1480;25:Nzf77imPM7+l4Upr0soGBisi96Scey7lUleMiVqI2kabK8oyUkTGpoXywXzRjEeXh2IwUO1iUlWM4g/3Skq5E4BxEHJ2qMqYiwbh5mT/ufz9In+gMjoR6g+llI7WgorHjhQBSOjf0YVJxCzVbXOtVyZnb0W5FViOfZhO6TLA/xsAFedLdwo1ECWjRfM+Pni7Ye4SfuloioSRwW7gfG7JxCMhBeyaTJ1Zm1CS3GBPoZA+wbXX8k3ZZ3VU3nOFx4OE+ip8fXJqW/2InHdA5J19HHwvPRPpKxwopmxCOfSYfS+QQ9/TLXbZor9G6a/gTMVzFQSWGQlciRx5FP/dG/nDVzYbOTPJCYgxlKJ9saxpWYfknSuUoLFvGVpJlIMsv3E+LnuQhCWLPHWwBPQXv4x/6QwhI35LxNcaEEFZo4EeN/f8Azd5j9aL5ofEps/xzgFQvR4OmFPUiufImyWuw3jEpL5XY3zzup+GmFMsz8fNbGPlGWr3mCCGDNmz8mGaN3cdj1g6ml+eywF/SdHuCAwgGw/PdhR9i+z4yzz3z1e1tJFLYwS5kG6XcYYvYTHDEp7Y/gftaQUvkH1tXT1CxlFXX5t9SOGaN1OQp1wpLWSxG2/RbmbOF57Us4F5FMDplXccph92FJPEcSb7Kfdllu6/gHQdla2MJIR6WUcsff7SntJgTuxs5GcshuEJ3OsGcWyo30QLIjNBdYrhahrl/wo1uXAiunpf4AwKkSmeWtdzJNA=;31:h4NclhUpnlyscmu9uEuSCOM+7kNyoRnMaqa6N/gIA5BsjNJJfQvx+/QG+4ZCU/I4sW7c1DiVtxw3TUzADqWBS7rCRRypbonMQuyE2K6HvZuv8JSFdgciYmOy9hPigyypE4V0CLoS3kdQzQOixXShqZpQZaCvzf4C8KjltO/vYRCk3a9QQxmKaph/LdGaFdwWOcSxgMUQlN6Mpo51u0wx4Q== X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1480;20:8MIu4baGPc829SadL8VPTFm5tHeJ/rbJ9MkLPNq4jZWTH/g8DbWT6dt7o/2vpz4ieNdkuXu3ygUoIUWypW2QFrLp+9Z9u0xEwvJCxztM1jr1WbQAwUWFd3Py1NWYvwbOw6HJN3smozXTKjG9zxzqS6Er2Nde6WS/63eczzyywSo=;4:v62nd/omNLkkLgq4tInD8oVc05dGQLjBahSLzPzjZhcbIbE3UGDtWv4zV8PiPLMdMqgrfeXr8w4bljPJIuu3ZIGbPR3mRCYDfnqvqCZJNTlhKqQyyGgux10Rr946hiNQMEJCkoD3cl0iDMdPmQ5V+jQnmL+0b9JuCbf6jqw69Pkmn69l+bt7x+t5aHE03+Ckd3vjOgQMLmZqsIErGS+yV3DZTPxgxJGYkTqbKWY63QhoJrnj612UE92PineBZejWR4GjWju972tjqSfa39VVG7ZCTEUPT7ZSmN54xzd0xpMI37m/jRGrm6F07FYz6pC9tsS8LBwXBxtZyGZBc7D+lhhjYrU11U60wzLA+FatWu4V6FuQkamHX6GGoCT+onKq7T8z2ApCrm+ZTe62wRrQ9Qcf/iU7tPfOfkhHG3OF6KGgeV9MmdymIKqsKY1XYl/R X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(80048183373757);UriScan:(80048183373757); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:BN3PR03MB1480;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1480;BCL:0;PCL:0;RULEID:(601004)(2401047)(13023025)(13015025)(13024025)(13018025)(8121501046)(5005006)(13017025)(3002001)(10201501046)(6055026);SRVR:BN3PR03MB2180;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB2180; X-Forefront-PRVS: 0016DEFF96 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(7916002)(199003)(189002)(24454002)(377454003)(65816999)(47776003)(230700001)(43066003)(101416001)(65956001)(19580405001)(2906002)(80316001)(53806999)(54356999)(76176999)(87266999)(42186005)(59896002)(19580395003)(586003)(65806001)(6116002)(105586002)(50986999)(3846002)(4326007)(81156014)(81166006)(8676002)(23676002)(2950100001)(66066001)(305945005)(50466002)(7736002)(4001350100001)(33656002)(97736004)(189998001)(86362001)(7846002)(77096005)(110136002)(64126003)(68736007)(99136001)(83506001)(106356001)(3450700001)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR03MB1480;H:[137.57.160.203];FPR:;SPF:None;PTR:InfoNoRecords;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?utf-8?B?MTtCTjNQUjAzTUIxNDgwOzIzOmtPSWJ4Yi9BUFp1V3llajVVZlJwcDNVZ1VS?= =?utf-8?B?bExFNERtVmk1MVlJZjNoaUQzZGRUanJZeTlZVGk3WmtMV0Z2VExNY2gvNHZD?= =?utf-8?B?QlhhSWZmVWV0d3lyMGNWRC9ubHljUE8xM1dZcGVZajROMVJMSTh6T2NhaWps?= =?utf-8?B?QkJXMW9BRCtXSTQ1bDNnR2JFaDZXdGRHbEwraDlGNklDd1NvSnBqd2JmZjBI?= =?utf-8?B?YVg0eU85VWV2QVNYZEZDZ0RpbmJtUTVGL0ZUS3QzZWtIRUk4b2xNNjFDZW9v?= =?utf-8?B?dSs5R0p2WGZ3NlFXNUt1R1R2bFNGVmRnSGFWbVJ5NXVZK3IwYUFnRU9yc3Jt?= =?utf-8?B?a1ZUckRlSmJoYURPWSt4S1JiS29Qa1pXUmk4K3NYQzVvc25naHB0TzY3RlNJ?= =?utf-8?B?QWJYVHVXTmZvS0RucUNkM2doT25udVVsQnFlQlFJbG0zNG1ncU8wdFMxSFVn?= =?utf-8?B?aGIvMDQxOHl6aWF5UzZJT2VkRElNMjdkTkVNTXBaWWhyVTZidldzelpEMFNZ?= =?utf-8?B?SWxVMjFwSnd6ZGdzaWVvS2lzbit1T2VYcUd0RDU5ZkdDOTFIZjZGTXU4bjc2?= =?utf-8?B?aVZybVRyK3NLZEZJbnp4d3Y0VDk0YWtLcnVaRDhwbG40Wjl2L3lRYlVwZzU2?= =?utf-8?B?VDVuVFNJVm1aQ2U3R2lhOTdFWVkzU0hDWENEWnFSSmRuYXZiaDJ4eXdYemdL?= =?utf-8?B?a3hOZEgxU0dyVGNrZVhkMU5KQ1hOd0EzckVlS2FocDgrOWdUbmFKR2ozZmsy?= =?utf-8?B?N2NmWFpkUktmb2V6RGJTSzJEa0huWGVxbFpoNW1Od2FUektwWkJ6bElmMmdh?= =?utf-8?B?TUNEL0YxZjFMbzg1RzFRV2h3bnBUa2pDdFV2U0dEVzlPeTl3RnRZRGQ1dGsy?= =?utf-8?B?Y0NpaFZ6d1BESkJzMlkzbXM5RkZCNlp6azJpVnFjUlZFd0hQTHlQQUJLcWlH?= =?utf-8?B?empCMVkrVXdqTDNNNkVXWGdvWTV6dlBPYUdHSm5hUGJDVGIvODY1SzBLR0Zi?= =?utf-8?B?YWlZbWJVcCtPa1BnZ3N2cW1ZRmJOUTZCbkh0NTRvQjNFMGNjKzlrWElEcnZy?= =?utf-8?B?MWVnaTY0b2grVzZIbzFmWGV1S1lPdmhQQUhrVXIwM0daMEFhS2Fjc2dnSTBp?= =?utf-8?B?SEhYODcyZ2srYzc5VDI1UExYdmxGbXR4RUlzb3gvVHpCZmVScmorSm9Xb09r?= =?utf-8?B?aWJ0M0VCa045UytZOHZXZmFob1RGQzBia2VJVDZjVTdsVURkdmdQeHNiM1U2?= =?utf-8?B?NEN6VWduUXFZblE1SVU2MG44eUJ2YzRNMnFmNnlxZWpnYTJxVUErRERpMlh5?= =?utf-8?B?bWtyeGVuTkNFeDB1NlJJbXlnTklSLyt5MWQzWkJ3SVdwUmZ5b1ViNUhSWVlJ?= =?utf-8?B?aGZXOXNtNWc2VnV2V3NCeWY3bTBRL2NETnpKemIwdG5SK3pGdG1wY0dmZktR?= =?utf-8?B?aWFpM0ZWZFFHQXM3Y2pUVzk3c3lyUklpSmk2UTdETjJCSzBFNXpUM3QxTk9w?= =?utf-8?B?bWltVUs3OVc3dU9qZEQybVRJV1ZhNTUvbkgybzd1OGIvV3pqOXdTSmpRTFJt?= =?utf-8?B?N2ZuS3Z1NGIvK3YrVzBEVEdaVTNIbi9CaUlUKzNDMVRQNDhyZGkrSGFZbDJZ?= =?utf-8?B?VkI5V3hRODEvL2pSN3JDSUhYNitGK2lyRWQ4cmU5eEtnQmo1U01YMStvdUVp?= =?utf-8?B?eXpibyt4bktvdjlKRWFnN29sWndyOTNiQW5wMmlORUN0YmljbklMZHliQ0Y5?= =?utf-8?Q?z/d4FK3dTxfsXzt9k96rBLIKu+crQvLhMwgvo=3D?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1480;6:333q7DHp9nfiBHMJBdUzlc5pnlcWOjP/VP4sxuNPPcTP/Lh5teNJhfWP/hB0eTmg0wD1sXUNA0M3s1LDbSJlxd7yQKGZXepgS9CYksL3ld1uOQh6jyIdsgcs39Lckx6P7uK2S7jLvoSUnGobCIsQJITSG7CsoUNdPaKLJrAW1/LtcdGmdas8l0k0FZs20w6pvr55S88iar1wTi0ZaoDayr+SynMM1lHCoVxgeZHRgqVJ3rVfW0xqdu3+Vlpsw1hrIiKIVZGp4CJRrfbPBYE9ru0WWPq50nhAnm573Rt5UFHyibK34nfcJpwjmtzcZg693/JsyLUcF9ngWRffuqnwKg==;5:1it9rountzbW0oDo86RNei9tivRpOyT7LTTyt0F/dd8LdRPItcj8cSnojnE62ha7ULOTOZN4gRQch/JEgtx1JV1c7bBcwKhM5RB9iedkE1QEpe1FKsuPF/uqhpglP2MDtNrzjIXEcWzbbJHaUb9s8A==;24:ODyu0cQ6hQF4gm/EcjIvijSYc0on4l3CbPXBhPwiZj1H9SJ08rRoIBS8c2CorwAmMB3b4smGuVYHphM7QG+6bsiw2I+Yva/PFGXA84eXUss=;7:Yjl2Yl+fVA49PL4/ZcPWG7N5maJ76lyLylQcf5rVNNjYfOJ5uPfGp9P5csr6Llyd3/v+J/OBfGLAjK20Sv6ZLSrwAXGZzYoiGwzD7udfVLlGN0+YxDPqJmEhvz/UGUWET/NlKWfOUHAtC3RGKEHhViB4ipmQEN+OFNKJUeZHwc3nfi/5kUKEXGIBG4A4ckAtwfsZi2MNjBqwyXIUX+H3XnYzc7IK/j3077HJq3HsUq1NRcqbJZKFHZMtGoEW4T7u SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1480;20:L03ZBQoU3IyQljMY6hyMbGrzsAXx7gWJsCGGpsR4FpQGXLgn6JXmOcfIQcQ8zPpeQ+S6yDh3fvU964Kuw0R1a2dAOeoNq4SJzvhX1I+RYq8hHAV9VIU/qfBI5rgtpvn+FRU4h9606Ihh5tMwbPu/aLqO9bbTFtV3hM/wOh29V74= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1480 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BY2FFO11FD026.protection.gbl X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:66.35.236.227;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(3190300001)(339900001)(377454003)(199003)(24454002)(189002)(110136002)(106466001)(6070500001)(87936001)(11100500001)(23676002)(50466002)(59896002)(99136001)(86362001)(4001350100001)(90366008)(65956001)(189998001)(105606002)(66066001)(47776003)(956001)(65806001)(97736004)(53806999)(76176999)(50986999)(80316001)(8936002)(81156014)(230700001)(16796002)(87266999)(8676002)(54356999)(85426001)(77096005)(2906002)(4326007)(83506001)(81166006)(3720700001)(64126003)(6806005)(68736007)(19580405001)(3846002)(6116002)(2950100001)(65816999)(586003)(7736002)(43066003)(19580395003)(33656002)(7846002)(356003)(305945005)(3450700001)(7099028)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR03MB2180;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD026;1:ty/bXnR09+/YmB3lDPLUuMkmxmPfdRc15+PP29Vs8fc8A7XcYsysHhJPaQX08Jm8o1grvg5a+1AE5JyWHM56VR5NsIlFjJZqd2iEB6IkvTG4l9VK4+N/ceXaBoMYgLi2GiT+zHv/WSuZr9E/ngc5vnsPCE51vVeRiq8fy8TAVfyyaMWA5QAkED0M0VeN0+ncYRat9KyDtFapzDMYLl/EjtpuyFdLq/HBReG+g1PK2/sunkufF3jyToiHeTtenVc3sBLGTVj7XDn5NXpTUUFk8cFhL3oV+9Bk0KTYT+Rq+kmAmv9m4BVOp06Bhzj9Qn9hRdTbCSV0VOXTlPi2nq6vjJ6lP9FvENzqt7J8+8nqm0aPeAne7Oocpz6rDxVyZ44byBkS3IEX3Ew+IAx2KeMgLkKXKKmq7OqGE17zILDZX2l2t2mJCR4khouZBluTEEJiP/xPXMX8tR5xz1sa9Ds9MFXsxEGgDFnpYpiHtXiP8vJhn0cIBs4hv2QgSPWjeZthSiCVZTzkdRycbPF+HbHWnQA3kEO8R5UJeDdjgodjdQnHpViW1qJU7Pmlpf6/TLnn2sDsYYtdw5lm3k/i+xIW90FebSg2JJzuj2QMbi67DvOflnwIwZounkFYYAMJLfp/ X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB2180;2:Fng1a6qOyxgChB8T2PLArxG7GrDP3inPafM1GI2wO7awqTv77LUiLbgqVJnQuHe5eT7n7QyVPWTybmZctp0sjMZAgS1UdYJtMY07KSzwq3ERkFE/4txHr4Q/lJWp1eEZjQ0thSn8McNWw+mLaWbbrzNZmPpFjX2cVOmnooA62YG/AzNt5sxgvyFsaUywnSad;3:3v0ThTHBS4m0jXusKQgCGuJ/Q8AhX4YejzM99Adj34ncBXBm/atEEUMAhkRPMu4zOdnAsArjR/gXtjhe8ZrJwjfrDG0xKNY/8xNvQYE33N1Ci63uI2rVipr0Tw0OJgpREvfh15cdPUqSiZpQegarvhqtDYNxwRO0kc5L8GjMi55cT2ozTVonH1+K0TfV+KxNVNSf+miduDQ9JRhTpi5o85zDARZlJk8rjIuC2GvTNjXmd13fz0ZoJS4UwLNldC+D X-DkimResult-Test: Passed X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(3001016);SRVR:BN3PR03MB2180; X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB2180;25:TKtTBwzu+496YmbcUF/a1dwtO4U7PCIWfD0GGxTSjkGDh9k5nqmEgiXqHPg/p1ynYo7nTKBV1vaDwYIIRWwfP4TMZwTupL7CT6xsi17bWPkCDbyguIE8nfY0b2Q4gEyWT7PP+nyLJdjllD8hvIgUqttIBvlJ/AgC+htLpC0GE2/z4Fa5Mq/LegRMz/XGlmrU/+53kO9jTIfXSkzyx95ckxDDyFf6z8WhcVcYZvWiUBiEkHQ1Inq7Dq/wtn1ix01OFZ+0Qhej9sHUJxWBvzbABsbBD4c0zvuh8RlM/AUPE5IpLtixdjRgKUhD/n6kIyMmXVb2ZdKREUA+cv7YvqEoh3+tnStjJpSykokRZzAHxpBUuFXjeNZLTE5ij6ML5+2WVm46qx7y4u4n9HuqWLo4r7R+kZT3F0fIaBpEyjcY6gD/GhVcrclcTmEgTJyCfzQvlTfmSUniRquMy9P0s5DXa/GG0cdXqldmiZG1FPbfq2dVdEI2ig+CbsUyrFIhnU3B7S3SFM6eCI/Ahn8gNt9uiEdoM1QYWSxnxyn0LK2rGVbKjWaXeiXiDxEFAjfrqTp3aD92Yaa0DuWirLtcFDehrJ8czre8s9T01sUVQlUUtLzt7OQ8JPE+quFuv3JqrrelNd5TBDVstK8mJHSqLViarKHkFrExJ9t314gTzCSWxsWLfJsNIkLuvldnw22HoNRDk5B9D/dus8QLUH8L01dbPT9lELORgC3E89dcvCd4A+KTx9sd8FtYXou3W1X0mLrq X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB2180;31:l8cIKCWciJAWBupY8S470xjF2AvjHSoTDStmP8aq/zk7c9XTJ5oJw1wbkwL1vxd0Cp1gtSgeHM0sLL9FPda09ZhipGQijXMs5rY0WJId6VdMSB2hIScmSHAFQlZ6suM21zjqHo2DdmhsnW0rH7DUkuO5ZvpHDytckz85Q0mI2Z0Rc5M5uZwq2W4jAoxugWMPd+ZFEK6mRkx/U9s5p0CO/g==;20:K84McD1pi9OdQU7j8ziafC7zp59qcQiDSFkF9qvvfH6cNiUGsML0ohjPHrdk01GbgsEveQmNbAaG2hgF0Gac+qDa4M+1GmcH2LXCLo5p4nSDqD6C7tdjgv3EGzRsDO4lIKJpBFZlvOUUwOCErj1DwRuYNA/sqrB1Eu5bnjORfn8=;4:gpckFPv4VK+BQbV/PWUH8SE8zuPnfXw8qFri3ELY26smE/1kRlQL1uOlgpS0E+l2y0A7ipJ5+OdkBtP7LGKJoj4S+UA2SUe5QkVhpcLJ/ZOThCNOp7Q0m3yv2o1ts4Bglv3kaew8NqanwfzPEIwTi1FrdV9oYcS0mPpjcQ2QSF/hfLgFai3+hR9OWZ00GME0E2FolPntHwhZAjGrb6/OOsko5OhMddFfg9QdOhlvCccVs7MH59oOOZTI2qQFdYxuw8RDJXQkh3cmWIa/5Y2tfiT2TSOV71iM6doiUm6kHt08cJDp2l6tlDkmJZFSonLO6v61npLgfeoKXYESRF5LmirGC3ROhSHE0hDnYNLcHsr+cXvGlW/A/2Y/0ZmTM9Z6APUf9PZDhM3xLRnQS8NCSUN8R2D+kxM+7XrmXM0064yEG7IPRuWXJtiiWBMz+Tv5hAiJefWrouNrXDEvtbnqKd08v9ed60ina0R7znnJVtCgcoAhKmkpsAmDCTwDkihg8YDjVCQ+Lp7bx8eQ+4ixAQ== X-Forefront-PRVS: 0016DEFF96 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjNQUjAzTUIyMTgwOzIzOm14ZGlpUlpDN3JRVDZGdXVRNmpYT1k3NHky?= =?utf-8?B?ZW9mQXkvZ1YydHFndEh4ZmtLejRsdW9RcHBFRmI5MllsYnZPM05HRFQ1andP?= =?utf-8?B?ZDEzTWd3QVN4N043aFY5dSs0bG01WnVvMjFkYUlQckRzd0syL2pvem4wVXZM?= =?utf-8?B?b2JGZFhRaEhPNzR0S2ovRXFZdndQSS84ZlpvVnlZb25XSER0Uk1qN2tMQ1Vx?= =?utf-8?B?WlpOUXY2NGN5VmZGSkJ6aVQ1SmlFV1F4WnJVVDF3Ynd1UzFlMkQvdWNxbDMy?= =?utf-8?B?QnZCVmtjZU1QTG1vNFZXdWZaSkZMUDJCVktibWlkWlI1K1ovc3VVbXk1WXUy?= =?utf-8?B?c083R2tvRmFwaVNlL2czNGNTUFcvSEp5cTQvL2NHVXVYRDJ3N0tvN0pkd1Zi?= =?utf-8?B?Rkl6N0Y3S296MjhhMzIxaWtBUHhlZzBYT3FDNTFBaXlZd043Z2Z0Z2hUZW12?= =?utf-8?B?SjVNVzc4SVpzdHkvekllQWVnOFFNSFRwcDhXZTVGL2N1MXc0TlVXeEN5U0xm?= =?utf-8?B?QjhuWHBqSFBpb1lPK3RSaExqWjN3bUd0d2IzQ1pDT3VJQUIyMFFwVXJ5bmFT?= =?utf-8?B?citMTGgzQ3RCVjd5NkgybnAydlc3NDZnVEhVTDdVdkFIN0p2Z21sOW5neWs3?= =?utf-8?B?bEpmeTRVNUhLYkgwY0R1cTRCQUpMSzQ0VXRKb2p2ZCtSZmtEQnI3akRFSllu?= =?utf-8?B?ekhZN00veXVSZjBzRUVPT1RqQWtUeEI1Qjl4Y0hIc0RwNlJOZkJxS0JsWVBW?= =?utf-8?B?bjh2ZmdBRHIyamxhWlRFR2NJRGtTK2hrWnE2V0lzNmV3M2hWY25PMkM2emcr?= =?utf-8?B?ZS9MUEZxRmNsa3ZCSDNtWUU0UHlaNnJHS0MzRWpQQU0vYVBaY2NiMGtycDhs?= =?utf-8?B?azJuWG5TWHFFb0xzand5ZGdUNDFRZGVMbG9rTW8xNmEzSi9aNGdhbktISGlT?= =?utf-8?B?bndNVTJYU1BzOFJUcGdDMzFkRVkzTmdVUWxaZnZGbWNyR0NVc2NNamVtbE4w?= =?utf-8?B?QmtiK3FWRmNmTnhrNk1rR1pNc3ZaejlpdGZRdEtMbGlZeHVjdjV2ajZBTUxQ?= =?utf-8?B?cDBSQSt6eEJhSFpFUnZIdjk4VTZzVFV1Y0hWd3c0ajJKWjd4VUp2OW1tTTIy?= =?utf-8?B?YVVBUFlMSkNKTUt6OEFrcGM1Qm15OFRIMkpKYUpHWDU5Y1BFczBnMFZUQ2JO?= =?utf-8?B?dFo1cmJPWWdJZFBOSy8zUEljQTNkenhRMmhKY2VSMnY0UmY1N2ExR3VEVmRs?= =?utf-8?B?S3FhSjNUWm9EaW1tQ3gyU2dRTzR6Z3ptd3JSSE1sTmxwb1Y1OTZVaW5PQjUz?= =?utf-8?B?NlhZWVY1QkF3dFJYVmxWbEN6STFJNXJ2bEpTcXRReCtHL2pPY1ZKNHZQME1l?= =?utf-8?B?Vis3V3ZIWkljZWc3cS95ZEduUEwzM1ZxS0pLbTRHczFCcDVQeldzc3B4ZzVt?= =?utf-8?B?OHc5a2RyTlBRWmVIaXUrelN6S25UQXFDTWJQNHNFNmdINWFFSXU3cFM3MTkx?= =?utf-8?B?ems5bmdGMDlSR0xmOVZ5c1F1TTdqcWZ0ZHM4NHYwUVBTMXlxaTdXQndnck80?= =?utf-8?B?VG50V0RybjBNb0RJNUVpamhNbzRBemFBdGxhamxTNElRME1sSVc2Zmc5ZzZq?= =?utf-8?B?L21wazF3RnFMZ3pTV3Z0elJGUmhDZVJlSjduU0d1cmhTZU1rWHRNU1B2VU9E?= =?utf-8?B?bnc5WmtGR3BLSVdYRW16RnEyOWFlVmhtcDJjRWhWMXVuU3lDMmRxSjF6ZFJD?= =?utf-8?B?N1ZVeVNBOE1VbkgyZkJsMTUzN1M1c2N1ZnVTdlVUTUVXdXRMeDM2SU9IeDZW?= =?utf-8?B?MitxVGFkcm9LZm04cWRDbVJHS3dZbXB2ZmFZVFY0UUxKUWx5SjV6bDBQZVR0?= =?utf-8?B?N2d0SlZyd3ZBbHpPQk55NmJRRFcwb3Y4OEY4MjVLby9QNjZuZzNSZ21oZUVQ?= =?utf-8?B?Rkdnc1ZyUytJTFF0Z2pMT3RmSURIUlVpTmxUdXVBYVJGMTMvNkRNZDF4cTZF?= =?utf-8?B?OGFPc3pOVGRSd01GcmJ0R3VVWWExL0lBTzlPVzVzdDhZNURDWi9McUxOMWNU?= =?utf-8?B?bHN2WTBCOWJqb3hKWWxDS0RTWXlhSDl5aEF2Y0ZOdjFxa0d2bXlYVGUvM0d5?= =?utf-8?Q?YckE9qOG+cp/OUQBKh3dDqQlDtxxf/xW403COxyixMmz?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB2180;6:oXQvl8dApKreB0S493m9kbVKUULwS0YCr4gCTOF571VBeLUTdE60CztWwZmOwDvJMMJuBiH8/x2Vf47pPvvftmVDdAB1/XeDcGqIfcsOigcrRqZZRID0PFdpyaoVEReoTDJ6rZyxTZfTWiNHdlmwZM+u17XcrPTpAzkW0/u5LAXX2e9qjuRVd6sO6jYBWYe9Tb1BltcacHRqHXSafZLBryf2k5rwnSdJRxsLkrLq5XLAezSHoJ0PQBonat17y9mm17cHjWoFzpr9MVp2cQY9qRSKD2BQ46lRW5VtTscTvjWyVSzbquqdLvdf6Z6r2VhKbOwWyfq5mOGhzZrOmx8r0g==;5:WrIPwVU6QHnOa7eryrLamA0MPRZfR/ILKzQ4If8l4wy2PelcGE9aPm3mEUxUF2wW/TvQD6/WgKCKUSKhPOTITp40BO0J6Z11PJOyFROT9EEooof137CvbEGhYFDLPAfUNMyqB8xNFyjQvJM/ssWj9Q==;24:cmtOb9GIc4iTcj+s4lgi7gQwbWYb/7Oit++1SDStW+c7Z5hJKZsITgAduUFZPtCZd1yQ3D9uhV+LoSid2ncPwkyeo4lNr6cRyXZE7fTi4JU=;7:XyBzETDHKgoaZKzwjLfYY+bxPLNJRnvfI047itW9YmKPihsHAPfQ+zHULk83+RJD49MiVu5N4LLQFg21CIHtfisI1rZfNqWiqymRFGik/gVhsGe6xs8y49G/5klT2rnu1NNsjSxqc0bhk++IW6EKqEELaFWIfqoQW63vF+V8Lu8YuYK1BmMl0U/HFNzFK5K2i1qTwyfQ7FowrHdJJsMl7A== X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB2180;20:EEYB4f3L5/p/xGx3BaGnPrzdpk5eo+ZMznrvigMf2VSQV6xsyjazEOC/y0dOshxXskBftC8sZxNkKRTb91BZY+LXUvAaHMbKdF+GP5GBzTt0+lNNPF3RRI4lP0Tn4Neepfs6Z4M2Yh8ciL/kn2i/+yequDydvou7eNPdlqMYQLw= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2016 18:37:37.1439 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/27/2016 12:10 PM, Borislav Petkov wrote: > On Thu, Jul 14, 2016 at 11:06:43AM -0500, tthayer@opensource.altera.com wrote: >> From: Thor Thayer >> >> Add Altera Arria10 NAND FIFO memory EDAC support. >> >> Signed-off-by: Thor Thayer >> --- >> drivers/edac/Kconfig | 7 +++++++ >> drivers/edac/altera_edac.c | 34 +++++++++++++++++++++++++++++++++- >> 2 files changed, 40 insertions(+), 1 deletion(-) > > ... > >> @@ -1589,7 +1619,9 @@ static int altr_edac_a10_probe(struct platform_device *pdev) >> else if ((of_device_is_compatible(child, >> "altr,socfpga-a10-ocram-ecc")) || >> (of_device_is_compatible(child, >> - "altr,socfpga-eth-mac-ecc"))) >> + "altr,socfpga-eth-mac-ecc")) || >> + (of_device_is_compatible(child, >> + "altr,socfpga-nand-ecc"))) >> altr_edac_a10_device_add(edac, child); >> else if (of_device_is_compatible(child, >> "altr,sdram-edac-a10")) > > Can we simplify this loop like this? > > for_each_child_of_node(pdev->dev.of_node, child) { > if (!of_device_is_available(child)) > continue; > > if (of_device_is_compatible(child, "altr,socfpga-a10-l2-ecc") || > of_device_is_compatible(child, "altr,socfpga-a10-ocram-ecc") || > of_device_is_compatible(child, "altr,socfpga-eth-mac-ecc") || > of_device_is_compatible(child, "altr,socfpga-nand-ecc")) > > altr_edac_a10_device_add(edac, child); > > else if (of_device_is_compatible(child, "altr,sdram-edac-a10")) > of_platform_populate(pdev->dev.of_node, > altr_sdram_ctrl_of_match, > NULL, &pdev->dev); > } > > I've merged the first "if" and subsequent "else if" because they all > do altr_edac_a10_device_add(edac, child) and added spacing for better > readability. > > Look ok? > > Or have I fatfingered it? > Yes, that's better. I was trying to stay within the 80 character limit but missed the if/else if improvement. Thanks, Boris! Should I re-submit? Thanks, Thor