From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932730AbcG1RSV (ORCPT <rfc822;w@1wt.eu>);
	Thu, 28 Jul 2016 13:18:21 -0400
Received: from smtp.citrix.com ([66.165.176.89]:20902 "EHLO SMTP.CITRIX.COM"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1758917AbcG1RSM (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 28 Jul 2016 13:18:12 -0400
X-IronPort-AV: E=Sophos;i="5.28,434,1464652800"; 
   d="scan'208";a="369042362"
Subject: Re: [Xen-devel] [PATCH linux] xen: change the type of xen_vcpu_id to
 uint32_t
To: Vitaly Kuznetsov <vkuznets@redhat.com>, <xen-devel@lists.xenproject.org>
References: <1469723086-22387-1-git-send-email-vkuznets@redhat.com>
CC: Juergen Gross <jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        <linux-kernel@vger.kernel.org>, Julien Grall <julien.grall@arm.com>,
        David Vrabel <david.vrabel@citrix.com>,
        "Boris Ostrovsky" <boris.ostrovsky@oracle.com>
From: David Vrabel <david.vrabel@citrix.com>
Message-ID: <579A3E4F.2050105@citrix.com>
Date: Thu, 28 Jul 2016 18:18:07 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.5.0
MIME-Version: 1.0
In-Reply-To: <1469723086-22387-1-git-send-email-vkuznets@redhat.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-DLP: MIA2
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 28/07/16 17:24, Vitaly Kuznetsov wrote:
> We pass xen_vcpu_id mapping information to hypercalls which require
> uint32_t type so it would be cleaner to have it as uint32_t. The
> initializer to -1 can be dropped as we always do the mapping before using
> it and we never check the 'not set' value anyway.
[...]
> --- a/include/xen/xen-ops.h
> +++ b/include/xen/xen-ops.h
> @@ -9,7 +9,7 @@
>  
>  DECLARE_PER_CPU(struct vcpu_info *, xen_vcpu);
>  
> -DECLARE_PER_CPU(int, xen_vcpu_id);
> +DECLARE_PER_CPU(uint32_t, xen_vcpu_id);
>  static inline int xen_vcpu_nr(int cpu)

Should the return type of this change to uint32_t as well?

>  {
>  	return per_cpu(xen_vcpu_id, cpu);
> 

David