From: "Limonciello, Mario" <mario.limonciello@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, Kees Cook <keescook@chromium.org>,
Thomas Lendacky <Thomas.Lendacky@amd.com>,
hughsient@gmail.com,
Martin Fernandez <martin.fernandez@eclypsium.com>,
linux-kernel@vger.kernel.org,
Brijesh Singh <brijesh.singh@amd.com>
Subject: Re: [PATCH v4] x86/cpu: clear SME feature flag when not in use
Date: Wed, 16 Feb 2022 07:41:59 -0600 [thread overview]
Message-ID: <579aec6b-78d1-57af-8e17-59cbe59f168a@amd.com> (raw)
In-Reply-To: <YgzTCtlMq9+4IsZ4@zn.tnic>
On 2/16/2022 04:33, Borislav Petkov wrote:
> On Tue, Feb 15, 2022 at 09:44:46PM -0600, Mario Limonciello wrote:
>> @@ -607,6 +609,9 @@ static void early_detect_mem_encrypt(struct cpuinfo_x86 *c)
>> if (IS_ENABLED(CONFIG_X86_32))
>> goto clear_all;
>>
>> + if (!sme_me_mask)
>> + setup_clear_cpu_cap(X86_FEATURE_SME);
>
> Why not "goto clear_all;" ?
>
"clear_all" clears SEV and SEV_ES as well which as pointed out in v2 is
incorrect.
next prev parent reply other threads:[~2022-02-16 13:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 3:44 [PATCH v4] x86/cpu: clear SME feature flag when not in use Mario Limonciello
2022-02-16 10:33 ` Borislav Petkov
2022-02-16 13:41 ` Limonciello, Mario [this message]
2022-02-16 15:05 ` Tom Lendacky
2022-02-16 20:16 ` [tip: x86/cpu] x86/cpu: Clear " tip-bot2 for Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=579aec6b-78d1-57af-8e17-59cbe59f168a@amd.com \
--to=mario.limonciello@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=hughsient@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.fernandez@eclypsium.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).