From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752565AbcHHUMT (ORCPT ); Mon, 8 Aug 2016 16:12:19 -0400 Received: from b.ns.miles-group.at ([95.130.255.144]:44723 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752300AbcHHUMT (ORCPT ); Mon, 8 Aug 2016 16:12:19 -0400 Subject: Re: [rcu:rcu/next 25/36] include/linux/irqflags.h:79:3: error: implicit declaration of function 'arch_irqs_disabled_flags' To: paulmck@linux.vnet.ibm.com References: <201606060200.kVmeQzvA%fengguang.wu@intel.com> <20160614225417.GR3923@linux.vnet.ibm.com> <5760FE41.9060603@nod.at> <20160615124532.GW3923@linux.vnet.ibm.com> Cc: kbuild test robot , kbuild-all@01.org, linux-kernel@vger.kernel.org, jdike@addtoit.com, user-mode-linux-devel@lists.sourceforge.net From: Richard Weinberger Message-ID: <57A8E79B.7020009@nod.at> Date: Mon, 8 Aug 2016 22:12:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <20160615124532.GW3923@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Paul, Am 15.06.2016 um 14:45 schrieb Paul E. McKenney: > On Wed, Jun 15, 2016 at 09:05:37AM +0200, Richard Weinberger wrote: >> Paul, >> >> Am 15.06.2016 um 00:54 schrieb Paul E. McKenney: >>> On Mon, Jun 06, 2016 at 02:04:03AM +0800, kbuild test robot wrote: >>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/next >>>> head: 13ee0de9cd2444b57ce30c4f1607b49b90aa0c38 >>>> commit: f251ac814fc5787765009e60d54a2bd4277350c8 [25/36] rcu: Make call_rcu_tasks() tolerate first call with irqs disabled >>>> config: um-allmodconfig (attached as .config) >>>> compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430 >>>> reproduce: >>>> git checkout f251ac814fc5787765009e60d54a2bd4277350c8 >>>> # save the attached .config to linux build tree >>>> make ARCH=um >>> >>> My kneejerk reaction would be to make CONFIG_TASKS_RCU depend on >>> !UML or something similar. >>> >>> Another approach would be create a arch_irqs_disabled_flags() for UML. >>> >>> Any preferences? >> >> Patches for arch_irqs_disabled_flags() support are already on LKML: >> https://lkml.org/lkml/2016/6/12/162 >> >> My plan was to merge them in the v4.8 merge window. >> So having CONFIG_TASKS_RCU depend on !UML for now should be fine. >> We can remove the dependency in v4.8 again. > > Sounds very good, thank you! The patch is now in Linus' tree. So, you can enable CONFIG_TASKS_RCU for UML again. :-) Thanks, //richard