From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752854AbcHNMwk (ORCPT ); Sun, 14 Aug 2016 08:52:40 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:51901 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751497AbcHNMwi (ORCPT ); Sun, 14 Aug 2016 08:52:38 -0400 Subject: Re: [PATCH] Staging: android: ion: ion.c: Compression of lines for To: Nadim almas , abbotti@mev.co.uk References: <1470161600-2904-1-git-send-email-nadim.902@gmail.com> Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org From: Vaishali Thakkar Message-ID: <57B06982.4080706@oracle.com> Date: Sun, 14 Aug 2016 18:22:18 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1470161600-2904-1-git-send-email-nadim.902@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 02 August 2016 11:43 PM, Nadim almas wrote: > This patch compresses two lines in to a single line in file > ion.c > if immediate return statement is found.It also removes variable > ret as it is no longer needed. > > ne using script Coccinelle. And coccinelle uses following semantic > patch for this compression function: Ok, so there is some improvement [copy-pasted commit log->commit log for the actual change] in commit log but there are some typos as well. Also, like all other your previous patches subject line is missing some words. For the commit log, subject line and patch version related things check Documentation/SubmittingPatches . > @@ > expression e, ret; > @@ > > -ret = > +return > e; > -return ret; > > Signed-off-by: Nadim Almas > --- > drivers/staging/android/ion/ion.c | 8 +++----- > > 1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c > index 52345df..271395b 100644 > --- a/drivers/staging/android/ion/ion.c > +++ b/drivers/staging/android/ion/ion.c > @@ -391,9 +391,7 @@ static int ion_handle_put_nolock(struct ion_handle *handle) > { > - int ret; > > - ret = kref_put(&handle->ref, ion_handle_destroy); > - > - return ret; > + return kref_put(&handle->ref, ion_handle_destroy); > } > > static int ion_handle_put(struct ion_handle *handle) > @@ -597,8 +595,8 @@ int ion_phys(struct ion_client *client, struct ion_handle *handle, > return -ENODEV; > } > mutex_unlock(&client->lock); > - ret = buffer->heap->ops->phys(buffer->heap, buffer, addr, len); > - return ret; > + return buffer->heap->ops->phys(buffer->heap, buffer, addr, len); Like mentioned by Laura in previous version of the patch, you are not supposed to send this patch in the kernel now. You can send the part of a patch [may be ion_handle_put_nolock one] if it will apply after her patches for the ion_phys. Also, for this patch Joe's compile-testing and unused variable related warning suggestion still applies. Please compile-test any patch before sending it in to the mainline. > } > EXPORT_SYMBOL(ion_phys); > > -- Vaishali