From: David Vrabel <david.vrabel@citrix.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
<david.vrabel@citrix.com>, <jgross@suse.com>
Cc: <xen-devel@lists.xenproject.org>, <bigeasy@linutronix.de>,
<linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH 2/2] xen/events: Convert to hotplug state machine
Date: Mon, 15 Aug 2016 16:06:25 +0100 [thread overview]
Message-ID: <57B1DA71.3020806@citrix.com> (raw)
In-Reply-To: <1471272407-4292-3-git-send-email-boris.ostrovsky@oracle.com>
On 15/08/16 15:46, Boris Ostrovsky wrote:
> From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>
> Install the callbacks via the state machine.
[...]
> +static int xen_evtchn_cpu_dead(unsigned int cpu)
> +{
> + __evtchn_fifo_handle_events(cpu, true);
> + return 0;
> +}
I'm not familiar with the new state machine. When this is called, what
state is the CPU in?
In particular, local interrupts must be disabled and all non-percpu irqs
must have been migrated to other CPUs.
> int __init xen_evtchn_fifo_init(void)
> {
> @@ -456,7 +444,9 @@ int __init xen_evtchn_fifo_init(void)
>
> evtchn_ops = &evtchn_ops_fifo;
>
> - register_cpu_notifier(&evtchn_fifo_cpu_notifier);
> + cpuhp_setup_state_nocalls(CPUHP_XEN_EVTCHN_PREPARE,
> + "CPUHP_XEN_EVTCHN_PREPARE",
> + xen_evtchn_cpu_prepare, xen_evtchn_cpu_dead);
> out:
> put_cpu();
> return ret;
> diff --git a/include/linux/cpuhotplug.h b/include/linux/cpuhotplug.h
> index d6beeb9..c60a17c 100644
> --- a/include/linux/cpuhotplug.h
> +++ b/include/linux/cpuhotplug.h
> @@ -22,6 +22,7 @@ enum cpuhp_state {
> CPUHP_SMPCFD_PREPARE,
> CPUHP_RCUTREE_PREP,
> CPUHP_XEN_PREPARE,
> + CPUHP_XEN_EVTCHN_PREPARE,
> CPUHP_NOTIFY_PREPARE,
> CPUHP_TIMERS_DEAD,
> CPUHP_BRINGUP_CPU,
>
next prev parent reply other threads:[~2016-08-15 15:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 14:46 [PATCH 0/2] Convert to new CPU hotplug framework Boris Ostrovsky
2016-08-15 14:46 ` [PATCH 1/2] xen/x86: Convert to hotplug state machine Boris Ostrovsky
2016-08-17 8:33 ` Sebastian Andrzej Siewior
2016-08-26 19:37 ` Boris Ostrovsky
2016-08-31 16:15 ` Sebastian Andrzej Siewior
2016-09-02 2:03 ` Boris Ostrovsky
2016-08-15 14:46 ` [PATCH 2/2] xen/events: " Boris Ostrovsky
2016-08-15 15:06 ` David Vrabel [this message]
2016-08-15 15:58 ` [Xen-devel] " Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57B1DA71.3020806@citrix.com \
--to=david.vrabel@citrix.com \
--cc=bigeasy@linutronix.de \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).