From: "\"Zhou, Wenjian/周文剑\"" <zhouwj-fnst@cn.fujitsu.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: <linux-kernel@vger.kernel.org>, <akpm@linux-foundation.org>,
<dyoung@redhat.com>, <bhe@redhat.com>, <vgoyal@redhat.com>,
<kexec@lists.infradead.org>, <linux-doc@vger.kernel.org>,
<xlpang@redhat.com>, <joe@perches.com>
Subject: Re: [PATCH v9 1/2] Documentation: kdump: remind user of nr_cpus
Date: Fri, 19 Aug 2016 08:33:21 +0800 [thread overview]
Message-ID: <57B653D1.8060106@cn.fujitsu.com> (raw)
In-Reply-To: <20160818111854.362bb972@lwn.net>
Hi Jonathan,
Thanks for your reply.
On 08/19/2016 01:18 AM, Jonathan Corbet wrote:
> On Thu, 18 Aug 2016 11:11:46 +0800
> Zhou Wenjian <zhouwj-fnst@cn.fujitsu.com> wrote:
>
> Thank you for working to improve the documentation!
>
>> * We generally don' have to bring up a SMP kernel just to capture the
>> dump. Hence generally it is useful either to build a UP dump-capture
>> kernel or specify maxcpus=1 option while loading dump-capture kernel.
>> + Note, though maxcpus always works, you should replace it by nr_cpus to
>> + save memory if supported by the current ARCH, such as x86.
>
> So, IMHO, this seems like the wrong place for this. I've just spent a bit
> of time staring at kernel-parameters.txt, and there is no way for a
> clueless user like me to know what the difference is between maxcpus= and
> nr_cpus= would be. A far better patch would be to update the
> documentation there to make that clear. Any chance you would be willing
> to do that?
>
> Then, rather than tacking an "ignore what you just read" note into
> kdump.txt, it could maybe be rewritten to simply say what users should do?
>
I was also confused by maxcpus and nr_cpus before writing this patch.
I think it is a good choice to describe it in kernel-parameters.txt.
Then, only two things need to be done I think.
One is move the above description to maxcpus= in kernel-parameters.txt.
And the other is replace maxcpus with maxcpus/nr_cpus in kdump.txt.
How do you think?
--
Thanks
Zhou
next prev parent reply other threads:[~2016-08-19 0:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 3:11 [PATCH v9 0/2] update the doc of kdump Zhou Wenjian
2016-08-18 3:11 ` [PATCH v9 1/2] Documentation: kdump: remind user of nr_cpus Zhou Wenjian
2016-08-18 17:18 ` Jonathan Corbet
2016-08-19 0:33 ` "Zhou, Wenjian/周文剑" [this message]
2016-08-19 15:57 ` Jonathan Corbet
2016-08-22 1:14 ` "Zhou, Wenjian/周文剑"
2016-08-24 5:06 ` Baoquan He
2016-08-25 19:10 ` Jonathan Corbet
2016-08-27 0:35 ` Baoquan He
2016-08-26 0:45 ` "Zhou, Wenjian/周文剑"
2016-08-27 0:38 ` Baoquan He
2016-08-18 3:11 ` [PATCH v9 2/2] Documentation: kdump: add description of enable multi-cpus support Zhou Wenjian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57B653D1.8060106@cn.fujitsu.com \
--to=zhouwj-fnst@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=corbet@lwn.net \
--cc=dyoung@redhat.com \
--cc=joe@perches.com \
--cc=kexec@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
--cc=xlpang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).