From: Kishon Vijay Abraham I <kishon@ti.com>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: <linux-kernel@vger.kernel.org>,
<linux-rockchip@lists.infradead.org>,
Heiko Stuebner <heiko@sntech.de>,
Doug Anderson <dianders@chromium.org>,
Brian Norris <briannorris@chromium.org>,
Wenrui Li <wenrui.li@rock-chips.com>,
Rob Herring <robh+dt@kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v4 2/2] phy: add a driver for the Rockchip SoC internal PCIe PHY
Date: Fri, 19 Aug 2016 19:05:43 +0530 [thread overview]
Message-ID: <57B70B2F.5090302@ti.com> (raw)
In-Reply-To: <1469755326-10263-2-git-send-email-shawn.lin@rock-chips.com>
Hi,
On Friday 29 July 2016 06:52 AM, Shawn Lin wrote:
> This patch to add a generic PHY driver for rockchip PCIe PHY.
> Access the PHY via registers provided by GRF (general register
> files) module.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>
> ---
>
> Changes in v4:
> - remove laneoff symbol as we still fail to get a workable solution
> except for exporting symbol. But I will be back with some other possible
> routine once finished.
>
> Changes in v3: None
> Changes in v2: None
>
> drivers/phy/Kconfig | 7 +
> drivers/phy/Makefile | 1 +
> drivers/phy/phy-rockchip-pcie.c | 357 ++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 365 insertions(+)
> create mode 100644 drivers/phy/phy-rockchip-pcie.c
>
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index 02afc624..824b568 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -371,6 +371,13 @@ config PHY_ROCKCHIP_DP
> help
> Enable this to support the Rockchip Display Port PHY.
>
> +config PHY_ROCKCHIP_PCIE
> + tristate "Rockchip PCIe PHY Driver"
> + depends on ARCH_ROCKCHIP && OF
add COMPILE_TEST here. I'm planning to fix this for other drivers as well in
drivers/phy.
> + select GENERIC_PHY
select MFD_SYSCON as well.
Thanks
Kishon
next prev parent reply other threads:[~2016-08-19 13:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-29 1:22 [PATCH v4 1/2] Documentation: bindings: add dt documentation for Rockchip PCIe PHY Shawn Lin
2016-07-29 1:22 ` [PATCH v4 2/2] phy: add a driver for the Rockchip SoC internal " Shawn Lin
2016-08-17 8:12 ` Shawn Lin
2016-08-19 13:35 ` Kishon Vijay Abraham I [this message]
2016-07-29 21:34 ` [PATCH v4 1/2] Documentation: bindings: add dt documentation for Rockchip " Rob Herring
2016-08-01 3:03 ` Shawn Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57B70B2F.5090302@ti.com \
--to=kishon@ti.com \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=wenrui.li@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).