From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755580AbcHWFXU convert rfc822-to-8bit (ORCPT ); Tue, 23 Aug 2016 01:23:20 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:49962 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752299AbcHWFXS (ORCPT ); Tue, 23 Aug 2016 01:23:18 -0400 X-AuditID: cbfee68d-f79286d000007a9a-4b-57bbddc0b120 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8BIT Message-id: <57BBDDBF.8040105@samsung.com> Date: Tue, 23 Aug 2016 14:23:11 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Lin Huang , heiko@sntech.de, myungjoo.ham@samsung.com Cc: tixy@linaro.org, mark.rutland@arm.com, typ@rock-chips.com, linux-rockchip@lists.infradead.org, airlied@linux.ie, mturquette@baylibre.com, dbasehore@chromium.org, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, dianders@chromium.org, kyungmin.park@samsung.com, sudeep.holla@arm.com, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mark.yao@rock-chips.com Subject: Re: [PATCH v7 4/8] Documentation: bindings: add dt documentation for dfi controller References: <1471836984-6316-1-git-send-email-hl@rock-chips.com> <1471836984-6316-5-git-send-email-hl@rock-chips.com> In-reply-to: <1471836984-6316-5-git-send-email-hl@rock-chips.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrCKsWRmVeSWpSXmKPExsWyRsSkUPfA3d3hBj0/uC16z51ksni1eQ+b xdllB9ksrnx9z2bx/9FrVosfG04xW5xtesNusenxNVaLy7vmsFl87j3CaPHpwX9mi6XXLzJZ 7JhygMni4ilXi9uNK9gsfpzpZrFYfmoHi8XC+ffZLWavrnMQ9lgzbw2jx/sbrewesxsusnhc 7utl8rhzbQ+bx/ZvD1g97ncfZ/LYvKTe4++s/SwefVtWMXpsvzaP2ePzJrkAnigum5TUnMyy 1CJ9uwSujLWXTzMVPOSruP9CvYHxPXcXIyeHhICJxOQ1/cwQtpjEhXvr2boYuTiEBFYwSpx7 2ssGU7T831ZmiMRSRoneTxcYQRK8AoISPybfYwGxmQXUJSbNW8QMYYtIfJoyixXC1pZYtvA1 VPMDRok9+zrZIJq1JObPWMwOYrMIqEqsaJsGNpQNKL7/xQ2wGn4BRYmrPx4DxTk4RAUiJLpP VIKERQR8JLbuOw12KbPAEmaJi+9+gc0RFoiT2P9wDQvEstOMEpN33AK7jlPAUeJy02pGkISE wBsOia9rt7BAbBaQ+Db5EAvIBgkBWYlNB6BhISlxcMUNlgmMErOQPDoLyaOzkDw6C8mjCxhZ VjGKphYkFxQnpRcZ6hUn5haX5qXrJefnbmIEJp7T/5717mC8fcD6EKMAB6MSD+8O9t3hQqyJ ZcWVuYcYTYEumsgsJZqcD0xveSXxhsZmRhamJqbGRuaWZkrivIpSP4OFBNITS1KzU1MLUovi i0pzUosPMTJxcEo1MLL86tGIn8/rJhWx/llIVpLmBtl3B3f/j6pSUSi4aW/7rP4nl9O+L3EZ jjO3bH27LSGe8eXtrwq/Wh2/pS7TvJn4ea3/TdstOU+OzM8MqFZYcTK2/vAk3Yl9aY4hrgqy UxY9n/vceblCfsctNVntQ6XdcY7RhrYaoc2Kgu5HF1p/ns/t1Vu3SImlOCPRUIu5qDgRAMn/ eEo3AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBKsWRmVeSWpSXmKPExsVy+t9jAd0Dd3eHG+y5w2LRe+4kk8WrzXvY LM4uO8hmceXrezaL/49es1r82HCK2eJs0xt2i02Pr7FaXN41h83ic+8RRotPD/4zWyy9fpHJ YseUA0wWF0+5WtxuXMFm8eNMN4vF8lM7WCwWzr/PbjF7dZ2DsMeaeWsYPd7faGX3mN1wkcXj cl8vk8eda3vYPLZ/e8Dqcb/7OJPH5iX1Hn9n7Wfx6NuyitFj+7V5zB6fN8kF8EQ1MNpkpCam pBYppOYl56dk5qXbKnkHxzvHm5oZGOoaWlqYKynkJeam2iq5+AToumXmAP2opFCWmFMKFApI LC5W0rfDNCE0xE3XAqYxQtc3JAiux8gADSSsYcx4dWAWa8Fhvoo/d9awNTBe5O5i5OSQEDCR WP5vKzOELSZx4d56ti5GLg4hgaWMEr2fLjCCJHgFBCV+TL7H0sXIwcEsIC9x5FI2SJhZQF1i 0rxFzBD1Dxgl9uzrZIOo15KYP2MxO4jNIqAqsaJtGtgcNqD4/hc3wGr4BRQlrv54zAgyU1Qg QqL7RCVIWETAR2LrvtNgNzALLGGWuPjuF9gcYYE4if0P17BALDvNKDF5xy0WkASngKPE5abV jBMYBWchuXUWwq2zkNy6gJF5FaNEakFyQXFSeq5RXmq5XnFibnFpXrpecn7uJkZwqnomvYPx 8C73Q4wCHIxKPLw38naHC7EmlhVX5h5ilOBgVhLhbbsCFOJNSaysSi3Kjy8qzUktPsRoCvTs RGYp0eR8YBrNK4k3NDYxM7I0Mje0MDI2VxLnffx/XZiQQHpiSWp2ampBahFMHxMHp1QDI/OM dTtWdGV3tmtKf3ivwMLO+mwNL+fGaxzqWw32sj3tdhQX6RPafur4AhsZVaecdgWljRM7fPk2 BxfL7k5QfRty5Pj72MPqMYGvf907uafhUGP+0h1bgxPqBKTTbMoqo+cE/w3hPxnwJPLXX623 b5qcNbU+9/6KnHR/Kav8MvE26QB5cQsGJZbijERDLeai4kQALnw7+2sDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lin, On 2016년 08월 22일 12:36, Lin Huang wrote: > This patch adds the documentation for rockchip dfi devfreq-event driver. > > Signed-off-by: Lin Huang > --- > Changes in v7: > -None > > Changes in v6: > -None > > Changes in v5: > -None > > Changes in v4: > -None > > Changes in v3: > -None > > Changes in v2: > -None > > Changes in v1: > -None > .../bindings/devfreq/event/rockchip-dfi.txt | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > create mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt > > diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt > new file mode 100644 > index 0000000..bf42255 > --- /dev/null > +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt > @@ -0,0 +1,20 @@ > + > +* Rockchip rk3399 DFI device > + > +Required properties: > +- compatible: Must be "rockchip,rk3399-dfi". > +- reg: physical base address of each DFI and length of memory mapped region > +- rockchip,pmu: phandle to the syscon managing the "pmu general register files" > +- clocks: phandles for clock specified in "clock-names" property > +- clock-names : the name of clock used by the DFI, must be "pclk_ddr_mon"; > + > +Example: > + dfi: dfi@0xff630000 { > + reg = <0x00 0xff630000 0x00 0x4000>; > + compatible = "rockchip,rk3399-dfi"; > + rockchip,pmu = <&pmugrf>; > + clocks = <&cru PCLK_DDR_MON>; > + clock-names = "pclk_ddr_mon"; > + status = "disabled"; > + }; > + > I reviewed this patch on previous version[1] already. [1] https://lkml.org/lkml/2016/8/16/913 There are minor requirement. If you modify it, I'll finish the review of this patch. -- Best Regards, Chanwoo Choi