From: Chanwoo Choi <cw00.choi@samsung.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
tomasz.figa@gmail.com, mturquette@baylibre.com, kgene@kernel.org,
k.kozlowski@samsung.com, chanwoo@kernel.org,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] clk: samsung: exynos5260: Move struct samsung_cmu_info to init section
Date: Thu, 25 Aug 2016 16:28:22 +0900 [thread overview]
Message-ID: <57BE9E16.7090309@samsung.com> (raw)
In-Reply-To: <20160825001109.GO19826@codeaurora.org>
Hi Stephen,
On 2016년 08월 25일 09:11, Stephen Boyd wrote:
> On 08/24, Chanwoo Choi wrote:
>> On 2016년 08월 24일 13:43, Stephen Boyd wrote:
>>> On 08/23, Sylwester Nawrocki wrote:
>>>> So the saving is rather insignificant but the patch doesn't make
>>>> things worse and I'd say it might be worth applying.
>>>>
>>>
>>> Sounds good. This sort of information should be in the commit
>>> text though. Talking about const doesn't make any sense to me.
>>
>> Do you mean that 'const' is initconst secion?
>
> No. Marking it as initconst in the patch is correct.
OK.
>
>> If possible, could you explain the anything
>> why you don't make sense about 'const'?
>>
>
> I'm just saying that the reasoning to move it from the text
> section to the data section shouldn't be because of const. There
> should be better reasons to do this, like size benefits.
>
As I already said, the samsung_cmu_register_on() requires
the 'const' type argument for 'struct samsung_cmu_info'.
So, I defined the instance on the out of the exynos5260_clk_aud_init() as following:
static const struct samsung_cmu_info aud_cmu __initconst = {
How can i add the 'const' keyword and '__initsecion' to the
"struct samsung_cmu_info aud_cmu" in the "static void __init
exynos5260_clk_aud_init(struct device_node *np)"?
--
Best Regards,
Chanwoo Choi
next prev parent reply other threads:[~2016-08-25 7:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 2:49 [PATCH 0/2] clk: samsung: Move struct samsung_cmu_info to init section Chanwoo Choi
2016-08-22 2:49 ` [PATCH 1/2] clk: samsung: exynos5260: " Chanwoo Choi
2016-08-23 0:55 ` Stephen Boyd
2016-08-23 2:35 ` Chanwoo Choi
2016-08-23 10:07 ` Sylwester Nawrocki
2016-08-24 4:43 ` Stephen Boyd
2016-08-24 8:38 ` Chanwoo Choi
2016-08-25 0:11 ` Stephen Boyd
2016-08-25 7:28 ` Chanwoo Choi [this message]
2016-08-25 14:43 ` Tomasz Figa
2016-09-01 17:06 ` Sylwester Nawrocki
2016-08-22 2:49 ` [PATCH 2/2] clk: samsung: exynos5410: Use samsung_cmu_register_one() to simplify code Chanwoo Choi
2016-09-01 17:07 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57BE9E16.7090309@samsung.com \
--to=cw00.choi@samsung.com \
--cc=chanwoo@kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@codeaurora.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).