From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753500AbcH0NqI (ORCPT ); Sat, 27 Aug 2016 09:46:08 -0400 Received: from regular1.263xmail.com ([211.150.99.134]:48878 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751140AbcH0NqH (ORCPT ); Sat, 27 Aug 2016 09:46:07 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: zhengxing@rock-chips.com X-FST-TO: arnd@arndb.de X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: zhengxing@rock-chips.com X-UNIQUE-TAG: <90ead992731288b2cdb2aea81521814c> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <57C19973.1050906@rock-chips.com> Date: Sat, 27 Aug 2016 21:45:23 +0800 From: Xing Zheng User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120410 Thunderbird/11.0.1 MIME-Version: 1.0 To: Arnd Bergmann CC: Mark Brown , Liam Girdwood , Heiko Stuebner , Sjoerd Simons , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: rockchip: use SPI dependency for rt5514 References: <20160826155120.1162512-1-arnd@arndb.de> In-Reply-To: <20160826155120.1162512-1-arnd@arndb.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On 2016年08月26日 23:50, Arnd Bergmann wrote: > The rk3399 scans the spi_bus_type to find the rt5514 driver, but does not > actually have a Kconfig dependency on SPI, so we can end up with a link > failure: > > sound/soc/codecs/snd-soc-rt5514-spi.o: In function `rt5514_spi_driver_init': > rt5514-spi.c:(.init.text+0x14): undefined reference to `__spi_register_driver' > sound/soc/codecs/snd-soc-rt5514-spi.o: In function `rt5514_spi_burst_read': > rt5514-spi.c:(.text.rt5514_spi_burst_read+0x18c): undefined reference to `spi_sync' > sound/soc/codecs/snd-soc-rt5514-spi.o: In function `rt5514_spi_burst_write': > rt5514-spi.c:(.text.rt5514_spi_burst_write+0x1b4): undefined reference to `spi_sync' > sound/soc/rockchip/snd-soc-rk3399-gru-sound.o: In function `rockchip_sound_probe': > rk3399_gru_sound.c:(.text.rockchip_sound_probe+0x128): undefined reference to `spi_bus_type' > > This adds the missing dependency. > > Signed-off-by: Arnd Bergmann > Fixes: c6eac8a36a84 ("ASoC: rockchip: Add machine driver for RK3399 GRU Boards") > --- > sound/soc/rockchip/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/rockchip/Kconfig b/sound/soc/rockchip/Kconfig > index d82d763d4854..c783f9a22595 100644 > --- a/sound/soc/rockchip/Kconfig > +++ b/sound/soc/rockchip/Kconfig > @@ -44,7 +44,7 @@ config SND_SOC_ROCKCHIP_RT5645 > > config SND_SOC_RK3399_GRU_SOUND > tristate "ASoC support multiple codecs for Rockchip RK3399 GRU boards" > - depends on SND_SOC_ROCKCHIP&& I2C&& GPIOLIB&& CLKDEV_LOOKUP > + depends on SND_SOC_ROCKCHIP&& I2C&& GPIOLIB&& CLKDEV_LOOKUP&& SPI > select SND_SOC_ROCKCHIP_I2S > select SND_SOC_MAX98357A > select SND_SOC_RT5514 So sorry to miss it... Thanks to help us to fix it. :-) Tested-by: Xing Zheng Thanks. -- - Xing Zheng