From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756465AbcH2Guz (ORCPT ); Mon, 29 Aug 2016 02:50:55 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:38398 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756285AbcH2GuK (ORCPT ); Mon, 29 Aug 2016 02:50:10 -0400 Subject: Re: [PATCH] clocksource/drivers/atmel-pit: Fix compilation error To: tglx@linutronix.de References: <1472453043-24287-1-git-send-email-daniel.lezcano@linaro.org> Cc: alexandre.belloni@free-electrons.com, realbright@lgcns.com, motobud@gmail.com, linux-kernel@vger.kernel.org From: Daniel Lezcano Message-ID: <57C3DB1E.1080008@linaro.org> Date: Mon, 29 Aug 2016 08:50:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1472453043-24287-1-git-send-email-daniel.lezcano@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/29/2016 08:44 AM, Daniel Lezcano wrote: > The previous fix introduced a check against the ret variable which > is not defined, hence producing a compilation error: > > linux/drivers/clocksource/timer-atmel-pit.c: In function ‘at91sam926x_pit_dt_init’: > linux/drivers/clocksource/timer-atmel-pit.c:264:2: error: ‘ret’ undeclared (first use in this function) > ret = clk_prepare_enable(data->mck); > ^ > linux/drivers/clocksource/timer-atmel-pit.c:264:2: note: each undeclared identifier is reported only once for each function it appears in > > Add the missing the variable 'ret'. > > Signed-off-by: Daniel Lezcano > --- Thomas, do you mind to directly apply this patch ? Thanks -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog