From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752640AbcIBJyo (ORCPT ); Fri, 2 Sep 2016 05:54:44 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:52430 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752158AbcIBJyk (ORCPT ); Fri, 2 Sep 2016 05:54:40 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee68d-f79286d000007a9a-cb-57c94c5da7d1 Content-transfer-encoding: 8BIT Message-id: <57C94C5C.8070406@samsung.com> Date: Fri, 02 Sep 2016 18:54:36 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Krzysztof Kozlowski Cc: k.kozlowski@samsung.com, kgene@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, jh80.chung@samsung.com, sw0312.kim@samsung.com, jy0922.shim@samsung.com, inki.dae@samsung.com, jonghwa3.lee@samsung.com, beomho.seo@samsung.com, jaewon02.kim@samsung.com, human.hwang@samsung.com, ideal.song@samsung.com, ingi2.kim@samsung.com, m.szyprowski@samsung.com, a.hajda@samsung.com, s.nawrocki@samsung.com, chanwoo@kernel.org Subject: Re: [PATCH v2 5/7] arm64: dts: exynos: Add dts files for Samsung Exynos5433 64bit SoC References: <1472046551-703-1-git-send-email-cw00.choi@samsung.com> <1472046551-703-6-git-send-email-cw00.choi@samsung.com> <20160826161442.GB15511@kozik-book> In-reply-to: <20160826161442.GB15511@kozik-book> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42JZI2JSqBvrczLcYOlzJYtb686xWpz+tI3d 4v2yHkaLiTeusFjMPwIUWzqjj9Vi19/7jBY7bn5hs5h0fwKLxY6GI6wWN361sVp0nn3CbPHi 3kUWi9cvDC36H79mtjh/fgO7xabH11gtLu+aw2Yx4/w+Jou1R+6yWyy9fpHJonXvEXaLw2/a WS1mTH7JZvHy4wkWB0mPNfPWMHpsWtXJ5rF5Sb1H35ZVjB6fN8kFsEZx2aSk5mSWpRbp2yVw Zdxru85ecMGsYkvDNqYGxnXaXYycHBICJhLt9zvYIWwxiQv31rOB2EICKxglOtdZdjFygNV0 tXN2MXIBhZcySry+d5kVpIZXQFDix+R7LCA1zALyEkcuZUOY6hJTpuRClD9glGh/txiqXEvi +oYjLCA2i4CqxJMtPxhBbDag+P4XN8DW8gsoSlz98ZgRZI6oQIRE94lKkLCIgKbE9b/fWUFm Mgs8Y5HY37GKCSQhLJAg8endThaIZd8ZJfa82AI2lFPAQOLMyweMIAkJgSccEl/WHGWE2Cwg 8W3yIRaIx2QlNh1ghvhdUuLgihssExjFZyF5bRbCa7MQXlvAyLyKUTS1ILmgOCm9yFCvODG3 uDQvXS85P3cTIzBtnP73rHcH4+0D1ocYBTgYlXh4PbxPhguxJpYVV+YeYjQFumEis5Rocj4w OeWVxBsamxlZmJqYGhuZW5opifMqSv0MFhJITyxJzU5NLUgtii8qzUktPsTIxMEp1cDYIfVT bV2Fl8X5aROXae+csmii2I3LFrVt1gsij3YdstgituJ7TFVMg8XVfSzGAnkFoSnvQ1+F/247 5eo/+ZCgUq+s7N/m2lqvBrmMc0ZpEXc7nm83dSu1qvn5feLB33GPAvWzlqsJbwqXYmz1Wzgr IDd5qgq3p43VJAHeXbvDHFb5flXY56vEUpyRaKjFXFScCACLv749FgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrIKsWRmVeSWpSXmKPExsVy+t9jAd1Yn5PhBrfWSVjcWneO1eL0p23s Fu+X9TBaTLxxhcVi/hGg2NIZfawWu/7eZ7TYcfMLm8Wk+xNYLHY0HGG1uPGrjdWi8+wTZosX 9y6yWLx+YWjR//g1s8X58xvYLTY9vsZqcXnXHDaLGef3MVmsPXKX3WLp9YtMFq17j7BbHH7T zmoxY/JLNouXH0+wOEh6rJm3htFj06pONo/NS+o9+rasYvT4vEkugDWqgdEmIzUxJbVIITUv OT8lMy/dVsk7ON453tTMwFDX0NLCXEkhLzE31VbJxSdA1y0zB+g/JYWyxJxSoFBAYnGxkr4d pgmhIW66FjCNEbq+IUFwPUYGaCBhDWPGvbbr7AUXzCq2NGxjamBcp93FyMEhIWAi0dXO2cXI CWSKSVy4t56ti5GLQ0hgKaPE63uXWUESvAKCEj8m32MBqWcWkJc4cikbwlSXmDIlF6L8AaNE +7vFUOVaEtc3HGEBsVkEVCWebPnBCGKzAcX3v7jBBmLzCyhKXP3xmBFkjqhAhET3iUqQsIiA psT1v99ZQWYyCzxjkdjfsYoJJCEskCDx6d1OFohl3xkl9rzYAjaUU8BA4szLB4wTGAVnITl1 FsKpsxBOXcDIvIpRIrUguaA4KT3XMC+1XK84Mbe4NC9dLzk/dxMjODk9k9rBeHCX+yFGAQ5G JR5eD++T4UKsiWXFlbmHGCU4mJVEeIu9gEK8KYmVValF+fFFpTmpxYcYTYF+ncgsJZqcD0yc eSXxhsYmZkaWRuaGFkbG5krivI//rwsTEkhPLEnNTk0tSC2C6WPi4JRqYOQLPJVZZrbQZbFt To3BIsnFxc0nDO0TxBbdvvpoPs/5lNpOtQ01Cz+UWCRd+pSwivfOypzPepLH5I9Njfn2gy1i 4eRVbTEvzPOuBU4+3H685cbqlw83Twy++a2tf6v74X9vGPU7H/Z0a/rNaejImrlW/+wlO9mz ++Im70xcJ3h+zzvDe483JyYosRRnJBpqMRcVJwIA79SozGQDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 08월 27일 01:14, Krzysztof Kozlowski wrote: > On Wed, Aug 24, 2016 at 10:49:09PM +0900, Chanwoo Choi wrote: >> This patch adds new Exynos5433 dtsi to support 64-bit Exynos5433 SoC based on >> Octa-core CPUs (quad Cortex-A57 and quad Cortex-A53). And Exynos5433 supports >> PSCI (Power State Coordination Interface) v0.1. >> >> This patch includes following Device Tree node to support Exynos5433 SoC: >> 1. Octa cores for big.LITTLE architecture >> - Cortex-A53 LITTLE Quad-core >> - Cortex-A57 big Quad-core >> - Support PSCI v0.1 >> >> 2. Clock controller node >> - CMU_TOP : clocks for IMEM/FSYS/G3D/GSCL/HEVC/MSCL/G2D/MFC/PERIC/PERIS >> - CMU_CPIF : clocks for LLI (Low Latency Interface) >> - CMU_MIF : clocks for DRAM Memory Controller >> - CMU_PERIC : clocks for UART/I2C/SPI/I2S/PCM/SPDIF/PWM/SLIMBUS >> - CMU_PERIS : clocks for PMU/TMU/MCT/WDT/RTC/SECKEY/TZPC >> - CMU_FSYS : clocks for USB/UFS/SDMMC/TSI/PDMA >> - CMU_G2D : clocks for G2D/MDMA >> - CMU_DISP : clocks for DECON/HDMI/DSIM/MIXER >> - CMU_AUD : clocks for Cortex-A5/BUS/AUDIO >> - CMU_BUS{0|1|2} : clocks for global data buses and global peripheral buses >> - CMU_G3D : clocks for 3D Graphics Engine >> - CMU_GSCL : clocks for GSCALER >> - CMU_APOLLO: clocks for Cortex-A53 Quad-core processor. >> - CMU_ATLAS : clocks for Cortex-A57 Quad-core processor, >> CoreSight and L2 cache controller. >> - CMU_MSCL : clocks for M2M (Memory to Memory) scaler and JPEG IPs. >> - CMU_MFC : clocks for MFC (Multi-Format Codec) IP. >> - CMU_HEVC : clocks for HEVC(High Efficiency Video Codec) decoder IP. >> - CMU_ISP : clocks for FIMC-ISP/DRC/SCLC/DIS/3DNR IPs. >> - CMU_CAM0 : clocks for MIPI_CSIS{0|1}/FIMC_LITE_{A|B|D}/FIMC_3AA{0|1} IPs. >> - CMU_CAM1 : clocks for COrtex-A5/MIPI_CSIS2/FIMC_LITE_C/FIMC-FD IPs. >> >> 3. pinctrl node for GPIO >> - alive/aud/cpif/ese/finger/fsys/imem/nfc/peric/touch pad >> >> 4. Timer >> - ARM architecture timer (armv8-timer) >> - MCT (Multi Core Timer) timer >> >> 5. Interrupt controller (GIC-400) >> >> 6. BUS devices >> - HS-I2C (High-Speed I2C) device >> - SPI (Serial Peripheral Interface) device >> >> 7. Sound devices >> - I2S bus >> - LPASS (Low Power Audio Subsystem) >> >> 8. Power management devices >> - CPUFREQ for for Cortex-A53/A57 >> - TMU (Thermal Management Unit) for Cortex-A53/A57, G3D, ISP >> >> 9. Display controller devices >> - DECON (Display and enhancement controller) for panel output >> - DSI (Display Serial Interface) >> - MIC (Mobile Image Compressor) >> >> 10. USB >> - USB 3.0 DRD (Dual Role Device) controller >> - USB 3.0 Host controller >> >> 11. Storage devices >> - MSHC (Mobile Stoarage Host Controller) >> >> 12. Misc devices >> - UART device >> - ADC (Analog Digital Converter) >> - PWM (Pulse Width Modulation) >> - ADMA (Advanced DMA) and PDMA (Peripheral DMA) >> >> Signed-off-by: Chanwoo Choi >> Signed-off-by: Jaehoon Chung >> Signed-off-by: Seung-Woo Kim >> Signed-off-by: Joonyoung Shim >> Signed-off-by: Inki Dae >> Signed-off-by: Jonghwa Lee >> Signed-off-by: Beomho Seo >> Signed-off-by: Jaewon Kim >> Signed-off-by: Hyungwon Hwang >> Signed-off-by: Inha Song >> Signed-off-by: Ingi kim >> Signed-off-by: Krzysztof Kozlowski >> Signed-off-by: Marek Szyprowski >> Signed-off-by: Andrzej Hajda >> Signed-off-by: Sylwester Nawrocki >> --- >> arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi | 792 ++++++++++++ >> .../dts/exynos/exynos5433-tmu-g3d-sensor-conf.dtsi | 23 + >> .../dts/exynos/exynos5433-tmu-sensor-conf.dtsi | 22 + >> arch/arm64/boot/dts/exynos/exynos5433-tmu.dtsi | 306 +++++ >> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 1327 ++++++++++++++++++++ >> 5 files changed, 2470 insertions(+) >> create mode 100644 arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi >> create mode 100644 arch/arm64/boot/dts/exynos/exynos5433-tmu-g3d-sensor-conf.dtsi >> create mode 100644 arch/arm64/boot/dts/exynos/exynos5433-tmu-sensor-conf.dtsi >> create mode 100644 arch/arm64/boot/dts/exynos/exynos5433-tmu.dtsi >> create mode 100644 arch/arm64/boot/dts/exynos/exynos5433.dtsi > > I got only one question: > > + >> + cooling-maps { >> + map0 { >> + /* Set maximum frequency as 1300MHz */ >> + trip = <&apollo_alert_0>; >> + cooling-device = <&cpu0 0 0>; > > Is cooling level=0 really a cooling level? I think it does nothing so it > should be just removed. You are right. I'll modify it for big cores as following: - cooling-device = <&cpu4 1 2>; Also, I'll use the only 5 step cooling level instead of 7 step. for LITTLE cores. For big cores: cooling-maps { map0 { /* Set maximum frequency as 1800MHz */ trip = <&atlas0_alert_0>; cooling-device = <&cpu4 1 2>; }; map1 { /* Set maximum frequency as 1700MHz */ trip = <&atlas0_alert_1>; cooling-device = <&cpu4 2 3>; }; map2 { /* Set maximum frequency as 1600MHz */ trip = <&atlas0_alert_2>; cooling-device = <&cpu4 3 4>; }; map3 { /* Set maximum frequency as 1500MHz */ trip = <&atlas0_alert_3>; cooling-device = <&cpu4 4 5>; }; map4 { /* Set maximum frequency as 1400MHz */ trip = <&atlas0_alert_4>; cooling-device = <&cpu4 5 7>; }; map5 { /* Set maximum frequencyas 1200MHz */ trip = <&atlas0_alert_5>; cooling-device = <&cpu4 7 9>; }; map6 { /* Set maximum frequency as 1000MHz */ trip = <&atlas0_alert_6>; cooling-device = <&cpu4 9 14>; }; }; For LITTLE cores: cooling-maps { map0 { /* Set maximum frequency as 1200MHz */ trip = <&apollo_alert_2>; cooling-device = <&cpu0 1 2>; }; map1 { /* Set maximum frequency as 1100MHz */ trip = <&apollo_alert_3>; cooling-device = <&cpu0 2 3>; }; map2 { /* Set maximum frequency as 1000MHz */ trip = <&apollo_alert_4>; cooling-device = <&cpu0 3 4>; }; map3 { /* Set maximum frequency as 900MHz */ trip = <&apollo_alert_5>; cooling-device = <&cpu0 4 5>; }; map4 { /* Set maximum frequency as 800MHz */ trip = <&apollo_alert_6>; cooling-device = <&cpu0 5 9>; }; }; > > The same for big cluster. > > Rest looks good. > > BR, > Krzysztof > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- Best Regards, Chanwoo Choi