From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753562AbcICANj (ORCPT ); Fri, 2 Sep 2016 20:13:39 -0400 Received: from regular1.263xmail.com ([211.150.99.138]:38648 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752695AbcICANg (ORCPT ); Fri, 2 Sep 2016 20:13:36 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: wxt@rock-chips.com X-FST-TO: heiko@sntech.de X-SENDER-IP: 104.132.1.81 X-LOGIN-NAME: wxt@rock-chips.com X-UNIQUE-TAG: <99affb11767685f445e57c5dcf4e0412> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <57CA159D.8050103@rock-chips.com> Date: Sat, 03 Sep 2016 08:13:17 +0800 From: Caesar Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Heiko Stuebner CC: Caesar Wang , Marc Zyngier , mark.rutland@arm.com, huangtao@rock-chips.com, Xing Zheng , devicetree@vger.kernel.org, Masahiro Yamada , Catalin Marinas , Brian Norris , Will Deacon , dianders@chromium.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , David Wu , cf@rock-chips.com, Jianqun Xu , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 0/2] arm64: dts: rockchip: Support PMU for rk3399 SoCs References: <1467792357-9749-1-git-send-email-wxt@rock-chips.com> In-Reply-To: <1467792357-9749-1-git-send-email-wxt@rock-chips.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Heiko, What do you think of it? Maybe I need re-update these patches on next kernel, and re-test them. On 2016年07月06日 16:05, Caesar Wang wrote: > Hello Heiko, Marc & ARM guys > > When Jay first submitted the rk3399.dtsi upstream > he had the PMU node in there, > but then took it out because the upstream binding wasn't done yet. > It looks as if the upstream stuff has landed, since in linux/master I see: > 287e9357abcc DT/arm,gic-v3: Documment PPI partition support > e3825ba1af3a irqchip/gic-v3: Add support for partitioned PPIs > 9e2c986cb460 irqchip: Add per-cpu interrupt partitioning library > 222df54fd8b7 genirq: Allow the affinity of a percpu interrupt to be set/retrieved > 651e8b54abde irqdomain: Allow domain matching on irq_fwspec > > This series patches add to support the rk3399 SoCs PMU. > I pick up the https://patchwork.kernel.org/patch/9209369/. > > As do some tests with ChromeOs for my rk3399 board. > Tested with linus master 4.7-rc6 kernel on rk3399 board. > https://github.com/Caesar-github/rockchip/tree/rk3399/pmu-upstream > > localhost / # perf list > > List of pre-defined events (to be used in -e): > cpu-cycles OR cycles [Hardware event] > instructions [Hardware event] > cache-references [Hardware event] > cache-misses [Hardware event] > branch-instructions OR branches [Hardware event] > branch-misses [Hardware event] > bus-cycles [Hardware event] > ... > > perf stat --cpu 0/1/2/3..... to minitor > e.g. cpu0; > > localhost / # perf stat --cpu 0 > > Performance counter stats for 'CPU(s) 0': > > 3374.917571 task-clock (msec) # 1.001 CPUs utilized [100.00%] > 20 context-switches # 0.006 K/sec [100.00%] > 2 cpu-migrations # 0.001 K/sec [100.00%] > 55 page-faults # 0.016 K/sec > 7151843 cycles # 0.002 GHz [100.00%] > stalled-cycles-frontend > stalled-cycles-backend > 4272536 instructions # 0.60 insns per cycle [100.00%] > 568406 branches # 0.168 M/sec [100.00%] > 65652 branch-misses # 11.55% of all branches > > Also, 'perf top' to monitor the PMU interrupts from cpus > > -Caesar > > > Changes in v2: > - AS Mark comments on https://patchwork.kernel.org/patch/9209369/ > remove the interrupt-affinity property, we need depend on Marc' perf > code on https://patchwork.kernel.org/patch/9209369/. > > Caesar Wang (2): > arm64: dts: rockchip: change all interrupts cells for 4 on rk3399 SoCs > arm64: dts: rockchip: support the pmu node for rk3399 > > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 118 ++++++++++++++++++------------- > 1 file changed, 69 insertions(+), 49 deletions(-) > -- caesar wang | software engineer | wxt@rock-chip.com