From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754336AbcICQ6Y (ORCPT ); Sat, 3 Sep 2016 12:58:24 -0400 Received: from www62.your-server.de ([213.133.104.62]:46634 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753239AbcICQ6W (ORCPT ); Sat, 3 Sep 2016 12:58:22 -0400 Message-ID: <57CB0124.1040605@iogearbox.net> Date: Sat, 03 Sep 2016 18:58:12 +0200 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: SF Markus Elfring , sparclinux@vger.kernel.org, Adam Buchbinder , Alexei Starovoitov , "David S. Miller" , Rabin Vincent CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini Subject: Re: [PATCH 3/4] sparc: bpf_jit: Avoid assignment for "flen" if BPF JIT is disabled References: <566ABCD9.1060404@users.sourceforge.net> <2bd51cac-bbb7-da76-9648-4ae24ba342b2@users.sourceforge.net> In-Reply-To: <2bd51cac-bbb7-da76-9648-4ae24ba342b2@users.sourceforge.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/03/2016 06:40 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 3 Sep 2016 18:00:03 +0200 > > Move the assignment for the local variable "flen" a bit at the beginning > so that it will only be performed if BPF JIT is enabled for this function. > > Signed-off-by: Markus Elfring Why is that a particular issue (did you measure some improvement when you say "fine-tuning" as per subject) ? That's all not in critical path here by the way, same for patch 2.