Re: cmsg newgroup alt.sex.fetish.bool (was Re: [PATCH] arch: all: include: asm: bitops: Use bool instead of int for all bit test functions)

From: Chen Gang <chengang@emindsoft.com.cn>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>,
	Al Viro <viro@ZenIV.linux.org.uk>
Cc: Arnd Bergmann <arnd@arndb.de>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"minchan@kernel.org" <minchan@kernel.org>,
	"vbabka@suse.cz" <vbabka@suse.cz>,
	"gi-oh.kim@profitbricks.com" <gi-oh.kim@profitbricks.com>,
	"iamjoonsoo.kim@lge.com" <iamjoonsoo.kim@lge.com>,
	"hillf.zj@alibaba-inc.com" <hillf.zj@alibaba-inc.com>,
	"mgorman@techsingularity.net" <mgorman@techsingularity.net>,
	"mhocko@suse.com" <mhocko@suse.com>,
	"rientjes@google.com" <rientjes@google.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"rth@twiddle.net" <rth@twiddle.net>,
	"ink@jurassic.park.msu.ru" <ink@jurassic.park.msu.ru>,
	"mattst88@gmail.com" <mattst88@gmail.com>,
	"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"will.deacon@arm.com" <will.deacon@arm.com>,
	"hskinnemoen@gmail.com" <hskinnemoen@gmail.com>,
	"egtvedt@samfundet.no" <egtvedt@samfundet.no>,
	"realmz6@gmail.com" <realmz6@gmail.com>,
	"ysato@users.sourceforge.jp" <ysato@users.sourceforge.jp>,
	"rkuo@codeaurora.org" <rkuo@codeaurora.org>,
	"tony.luck@intel.com" <tony.luck@intel.com>,
	"fenghua.yu@intel.com" <fenghua.yu@intel.com>,
	"geert@linux-m68k.org" <geert@linux-m68k.org>,
	"james.hogan@imgtec.com" <james.hogan@imgtec.com>,
	"ralf@linux-mips.org" <ralf@linux-mips.org>,
	"dhowells@redhat.com" <dhowells@redhat.com>,
	"deller@gmx.de" <deller@gmx.de>,
	"benh@kernel.crashing.org" <benh@kernel.crashing.org>,
	"paulus@samba.org" <paulus@samba.org>,
	"mpe@ellerman.id.au" <mpe@ellerman.id.au>,
	"schwidefsky@de.ibm.com" <schwidefsky@de.ibm.com>,
	"heiko.carstens@de.ibm.com" <heiko.carstens@de.ibm.com>,
	"dalias@libc.org" <dalias@libc.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: cmsg newgroup alt.sex.fetish.bool (was Re: [PATCH] arch: all: include: asm: bitops: Use bool instead of int for all bit test functions)
Date: Sun, 04 Sep 2016 06:36:56 +0800	[thread overview]
Message-ID: <57CB5088.6050007@emindsoft.com.cn> (raw)
In-Reply-To: <8f1f06e3-0ca1-dfec-3ccf-ca155c61fdc6@synopsys.com>

On 9/3/16 08:07, Vineet Gupta wrote:
> On 09/02/2016 04:33 PM, Chen Gang wrote:
>> On 9/2/16 04:43, Al Viro wrote:
>>>>
>>>> Can you show a proof that it actually improves anything?  He who proposes
>>>> a patch gets to defend it, not the other way round...
>>>>
>>>> Al, bloody annoyed
>>>>
>> OK, what you said sounds reasonable to me.
>>
>> It makes the code more readable since they are really pure Boolean
>> functions, and let the functions are precisely same in all archs. But
>> really, I shall try to prove that it has no negative effect.
>>
>> e.g. for arc arch. now, I have built the arc raw compiler to build arc
>> kernel, but excuse me, I plan to finish proof next week, because during
>> these days, I have to work, buy house, and focus on my father's health.
> 
> Since you seem to be have so much stuff to do I decided to help. I did a quick
> compile of kernel with and w/o your changes
> 
> bloat-o-meter vmlinux-v4.8rc4-baseline vmlinux-v4.8rc4-bool-in-atomics
> add/remove: 0/0 grow/shrink: 1/0 up/down: 6/0 (6)
> function                                     old     new   delta
> vermagic                                      49      55      +6
> Total: Before=5967447, After=5967453, chg 0.000000%
> 
> I'm mildly surprised that there is no difference so yeah this change is fine as
> far as I'm concerned.
> 

Thank you for your reply :-)

And for all: shall I provide the proof for another archs?

For me, Boolean gives additional chance to compiler to improve the code.
If the compiler can not improve the code, it can treat it as int simply.
So theoretically, at least, Boolean should not be worse than int.

Thanks.
-- 
Chen Gang (陈刚)

Managing Natural Environments is the Duty of Human Beings.