From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753179AbcIDJ5S (ORCPT ); Sun, 4 Sep 2016 05:57:18 -0400 Received: from www62.your-server.de ([213.133.104.62]:41607 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752156AbcIDJ5O (ORCPT ); Sun, 4 Sep 2016 05:57:14 -0400 Message-ID: <57CBEFEA.3080007@iogearbox.net> Date: Sun, 04 Sep 2016 11:56:58 +0200 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Jonathan Corbet CC: SF Markus Elfring , David Miller , sparclinux@vger.kernel.org, Adam Buchbinder , Alexei Starovoitov , Rabin Vincent , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini , linux-doc@vger.kernel.org, Jean Delvare Subject: Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile() References: <57CAFFDC.4030606@iogearbox.net> <20160903.230607.1667562673788737377.davem@davemloft.net> <1365a588-c7c7-717c-1e3d-ceabd71e8479@users.sourceforge.net> <20160903.235916.1892276070318494855.davem@davemloft.net> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/04/2016 09:20 AM, SF Markus Elfring wrote: >>> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/Documentation/CodingStyle?id=865a1caa4b6b886babdd9d67e7c3608be4567a51 [ + Jonathan for above commit in linux-next ] >> You seem to lack understanding of the difference between absolute >> requirements and "advice". >> >> As Sparc maintainer I can choose to not take this "advice", >> and I so choose to do so. > > Your conclusion can be fine in principle. > > I am just curious on how much further software development "fun" the recent update > by a topic like "CodingStyle: Clarify and complete chapter 7" will trigger. I don't want to drag this thread onwards for (way) too long, but clearly "it is advised to indent labels with a single space (not tab)" (from diff in above commit) doesn't really reflect the majority of kernel practice we have in-tree today and actually rather adds more confusion than any clarification whatsoever: $ git grep -n "^\ [a-z_]*:" -- '*.[ch]' | wc -l 4919 $ git grep -n "^[a-z_]*:" -- '*.[ch]' | wc -l 54686 A CodingStyle document should document what's regarded as a general consensus of kernel coding practices, and thus should represent the /majority/ of coding style, which (if I didn't screw up my git-grep line completely) above 9% does not really reflect at all. So, new folks starting with kernel hacking reading this are rather misguided, and code-wise it just adds up to have more inconsistencies from new patches, or worse, have noisy patches (like this one) flying around that try to brute-force everything into this advice.