From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754101AbcIDRfl (ORCPT ); Sun, 4 Sep 2016 13:35:41 -0400 Received: from www62.your-server.de ([213.133.104.62]:43499 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752138AbcIDRfj (ORCPT ); Sun, 4 Sep 2016 13:35:39 -0400 Message-ID: <57CC540C.6070701@iogearbox.net> Date: Sun, 04 Sep 2016 19:04:12 +0200 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: SF Markus Elfring CC: Jonathan Corbet , David Miller , sparclinux@vger.kernel.org, Adam Buchbinder , Alexei Starovoitov , Rabin Vincent , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini , linux-doc@vger.kernel.org, Jean Delvare Subject: Re: Clarification for source code formatting around jump labels References: <57CAFFDC.4030606@iogearbox.net> <20160903.230607.1667562673788737377.davem@davemloft.net> <1365a588-c7c7-717c-1e3d-ceabd71e8479@users.sourceforge.net> <20160903.235916.1892276070318494855.davem@davemloft.net> <57CBEFEA.3080007@iogearbox.net> <50edcf58-112e-0b89-4265-7c39d2f147ca@users.sourceforge.net> In-Reply-To: <50edcf58-112e-0b89-4265-7c39d2f147ca@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-Authenticated-Sender: daniel@iogearbox.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/04/2016 03:50 PM, SF Markus Elfring wrote: >>> I am just curious on how much further software development "fun" the recent update >>> by a topic like "CodingStyle: Clarify and complete chapter 7" will trigger. >> >> I don't want to drag this thread onwards for (way) too long, but clearly "it is >> advised to indent labels with a single space (not tab)" (from diff in above commit) > > How do you think about the reason (which you omitted from your quotation) for this advice? > > “…, > so that "diff -p" does not confuse labels with functions. > …” Yep, since this recently came up in a different thread as well, please see here, for example: http://patchwork.ozlabs.org/patch/664966/ >> doesn't really reflect the majority of kernel practice we have in-tree today and >> actually rather adds more confusion than any clarification whatsoever: >> >> $ git grep -n "^\ [a-z_]*:" -- '*.[ch]' | wc -l >> 4919 >> $ git grep -n "^[a-z_]*:" -- '*.[ch]' | wc -l >> 54686 > > So there is a mixture already. > [...] > In which ways would you prefer that the style specifications should be > clarified further? > > Where should source code become more consistent? It would likely make sense to document that git config mentioned in the link above as a recommendation for that paragraph, and stick with what is used in the vast majority of cases already, meaning no leading space before labels.