From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936358AbcIFP3D (ORCPT ); Tue, 6 Sep 2016 11:29:03 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:48521 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933304AbcIFP24 (ORCPT ); Tue, 6 Sep 2016 11:28:56 -0400 Subject: Re: [PATCH 1/2] perf tools: Introduce memory mapping macros in mman-fix.h To: Arnaldo Carvalho de Melo References: <1473140932-143524-1-git-send-email-wangnan0@huawei.com> <1473140932-143524-2-git-send-email-wangnan0@huawei.com> <20160906125902.GB5456@kernel.org> <57CEC3DB.1080800@huawei.com> <20160906133902.GA11557@kernel.org> CC: , , , Hou Pengyang , He Kuang , Arnaldo Carvalho de Melo From: "Wangnan (F)" Message-ID: <57CEE0A3.4040201@huawei.com> Date: Tue, 6 Sep 2016 23:28:35 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160906133902.GA11557@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.66.109] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.57CEE0AE.0319,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 652a81d1d6b6b0bf86af7f8854f14da8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/9/6 21:39, Arnaldo Carvalho de Melo wrote: > Em Tue, Sep 06, 2016 at 09:25:47PM +0800, Wangnan (F) escreveu: >> >> On 2016/9/6 20:59, Arnaldo Carvalho de Melo wrote: >>> Em Tue, Sep 06, 2016 at 05:48:51AM +0000, Wang Nan escreveu: >>>> tools/perf/trace/beauty/mmap.c, tools/perf/util/event.c and >>>> tools/perf/util/map.c depend on several macros in mman.h, which >>>> are lost on old systems like ubuntu 12.04. They are architecture >>> Not "lost on old systems", changing that to "not present on old systems" >>> >>>> dependened macros. Importing ./arch/*/include/uapi/asm/mman.h >>>> into tools/ is not easy because mman.h for some unusual archs >>>> (like tile) have extra dependencies. >>>> This patch introduces only required macros into mman-fix.h. >>>> Macros list is gotten from tools/perf/trace/beauty/mmap.c. >>> ok, I'll try keeping the include/uapi/asm-generic/mman.h and >>> arch/alpha/include/uapi/asm/mman.h with just what you added, so that at >>> least the .c files appears as using the headers were those things are >>> defined in the kernel sources. >>> >>> Ah, and good eyes in realizing this is not the same value for all >>> arches! >> This is why we have to define these macros for each archs. >> Your solution in tools/perf/trace/beauty/mmap.c works for >> x86 only. >> >> However, I don't like this patchset because we add 300+ >> lines of code and 22 new files for less than 15 macros, >> and only one of them I really concern. Moreover, futhre >> code require more symbols in uapi and we have to add new >> headers, finally we will clone the whole uapi. We have >> to stop doing this... > Why? If we want to support older newer kernels running on older distros, > which is a valid goal, or recent tool source code on older distros, > where fallbacks will take place with their older kernels, and if we have > the build automated for that (I have) then why not keep the tools > building on as many different userspaces as possible? Your automated building checker is great. I mean we have to find a way to stop pulling kernel headers to tools/include. But since we haven't find such a way, I'll continously improve this mman.h stuff. As your suggestion, I'll try to put them in uapi/mman.h, not mman-fix.h. This require a building check for each arch. Thank you.