From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758568AbcIHUYy (ORCPT <rfc822;w@1wt.eu>);
        Thu, 8 Sep 2016 16:24:54 -0400
Received: from mga04.intel.com ([192.55.52.120]:50626 "EHLO mga04.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1758498AbcIHUYx (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 8 Sep 2016 16:24:53 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,302,1470726000"; 
   d="scan'208";a="6281188"
Subject: Re: [PATCH V4] mm: Add sysfs interface to dump each node's zonelist
 information
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <1473150666-3875-1-git-send-email-khandual@linux.vnet.ibm.com>
 <1473302818-23974-1-git-send-email-khandual@linux.vnet.ibm.com>
Cc: akpm@linux-foundation.org
From: Dave Hansen <dave.hansen@intel.com>
Message-ID: <57D1C914.9090403@intel.com>
Date: Thu, 8 Sep 2016 13:24:52 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <1473302818-23974-1-git-send-email-khandual@linux.vnet.ibm.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/07/2016 07:46 PM, Anshuman Khandual wrote:
> after memory or node hot[un]plug is desirable. This change adds one
> new sysfs interface (/sys/devices/system/memory/system_zone_details)
> which will fetch and dump this information.

Doesn't this violate the "one value per file" sysfs rule?  Does it
belong in debugfs instead?

I also really question the need to dump kernel addresses out, filtered
or not.  What's the point?