From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753287AbcIJC7d (ORCPT ); Fri, 9 Sep 2016 22:59:33 -0400 Received: from regular1.263xmail.com ([211.150.99.136]:55730 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751537AbcIJC7c (ORCPT ); Fri, 9 Sep 2016 22:59:32 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED4: 1 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: xie.baoyou@zte.com.cn X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] drm/rockchip: add missing header dependencies To: Baoyou Xie , airlied@linux.ie, heiko@sntech.de References: <1473245580-538-1-git-send-email-baoyou.xie@linaro.org> Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, arnd@arndb.de, xie.baoyou@zte.com.cn From: Mark yao Message-ID: <57D37707.8050607@rock-chips.com> Date: Sat, 10 Sep 2016 10:59:19 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1473245580-538-1-git-send-email-baoyou.xie@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年09月07日 18:53, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c:130:5: warning: no previous prototype for 'rockchip_drm_fbdev_init' [-Wmissing-prototypes] > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c:173:6: warning: no previous prototype for 'rockchip_drm_fbdev_fini' [-Wmissing-prototypes] > > In fact, these functions are declared > in drivers/gpu/drm/rockchip/rockchip_drm_fbdev.h, > so this patch adds missing header dependencies. > > Signed-off-by: Baoyou Xie > --- > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 1 + > 1 file changed, 1 insertion(+) Applied to my drm-fixes, Thanks > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c > index 207e01d..a16c69f 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c > @@ -20,6 +20,7 @@ > #include "rockchip_drm_drv.h" > #include "rockchip_drm_gem.h" > #include "rockchip_drm_fb.h" > +#include "rockchip_drm_fbdev.h" > > #define PREFERRED_BPP 32 > #define to_drm_private(x) \ -- Ｍark Yao