From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761237AbcINKYb (ORCPT ); Wed, 14 Sep 2016 06:24:31 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:15383 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756012AbcINKY3 (ORCPT ); Wed, 14 Sep 2016 06:24:29 -0400 Subject: Re: [PATCH 1/3] tools include: Add uapi mman.h for each architecture To: "Naveen N. Rao" References: <1473684871-209320-1-git-send-email-wangnan0@huawei.com> <1473684871-209320-2-git-send-email-wangnan0@huawei.com> <20160912190742.GG4897@kernel.org> <20160912211520.GA10582@kernel.org> <20160914092810.GA21691@naverao1-tp.localdomain> <57D91A36.5060505@huawei.com> <20160914100018.GB21691@naverao1-tp.localdomain> CC: Arnaldo Carvalho de Melo , , , From: "Wangnan (F)" Message-ID: <57D92524.6050704@huawei.com> Date: Wed, 14 Sep 2016 18:23:32 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160914100018.GB21691@naverao1-tp.localdomain> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.66.109] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.57D92550.00E4,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 496643d6f8a6c83a5ee0cdddfcb4f062 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/9/14 18:00, Naveen N. Rao wrote: > On 2016/09/14 05:36PM, Wang Nan wrote: >> >> On 2016/9/14 17:28, Naveen N. Rao wrote: >>> On 2016/09/12 06:15PM, Arnaldo Carvalho de Melo wrote: >>>> Em Mon, Sep 12, 2016 at 04:07:42PM -0300, Arnaldo Carvalho de Melo escreveu: >>>>> Em Mon, Sep 12, 2016 at 12:54:29PM +0000, Wang Nan escreveu: >>>>>> Some mmap related macros have different values for different >>>>>> architectures. This patch introduces uapi mman.h for each >>>>>> architectures. >>>>>> >>>>>> Three headers are cloned from kernel include to tools/include: >>>>>> >>>>>> tools/include/uapi/asm-generic/mman-common.h >>>>>> tools/include/uapi/asm-generic/mman.h >>>>>> tools/include/uapi/linux/mman.h >>>>> Cool, the above was done as copies, why not the rest? IIRC you mentioned >>>>> some reasoning behind that decision, but we need it spelled out here. >>>>> >>>>> For instance, I went on and look at arch/xtensa/include/uapi/asm/mman.h, >>>>> and couldn't find why we shouldn't copy it just like the three files >>>>> above. >>>>> >>>>> I'm looking now at why the build breaks in so many systems, first hunch >>>>> is that bits/ part (the ones without the failure details probably have >>>>> the same errors), alpine uses musl libc, but some that broke are glibc >>>>> based. >>>> So, please take a look at my perf/core branch, I applied 1/3 and 3/3, >>>> but took a different path for 2/3, now it builds for all systems I have >>>> containers for: >>> This still fails for me on ppc64. Perhaps we should guard >>> P_MMAP_FLAG(32BIT) and potentially others with a #ifdef, which was >>> earlier reverted by commit 256763b0 ("perf trace beauty mmap: Add more >>> conditional defines")? >> Perhaps we should set all non-exist flag to 0 in each uapi mman.h? > Will that work for MADV_* since the macro there is for a case statement? Then fall back to include/uapi/asm-generic/mman-common.h. And I realized the missing of MADV_FEEE in tools/perf/trace/beauty/mmap.c. Is that intentionally? Thank you.