From: David Vrabel <david.vrabel@citrix.com>
To: Kyle Huey <me@kylehuey.com>, "Robert O'Callahan" <robert@ocallahan.org>
Cc: Juergen Gross <jgross@suse.com>, Len Brown <len.brown@intel.com>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Kristen Carlson Accardi <kristen@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
"maintainer:X86 ARCHITECTURE 32-BIT AND 64-BIT" <x86@kernel.org>,
Huang Rui <ray.huang@amd.com>,
"open list:X86 ARCHITECTURE 32-BIT AND 64-BIT"
<linux-kernel@vger.kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
"Aravind Gopalakrishnan" <aravind.gopalakrishnan@amd.com>,
David Vrabel <david.vrabel@citrix.com>,
Andy Lutomirski <luto@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
"moderated list:XEN HYPERVISOR INTERFACE"
<xen-devel@lists.xenproject.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Borislav Petkov <bp@suse.de>,
Thomas Gleixner <tglx@linutronix.de>,
Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Subject: Re: [Xen-devel] [PATCH v2 2/3] x86 Test and expose CPUID faulting capabilities in /proc/cpuinfo
Date: Thu, 15 Sep 2016 11:05:02 +0100 [thread overview]
Message-ID: <57DA724E.6090606@citrix.com> (raw)
In-Reply-To: <1473886902-17902-3-git-send-email-khuey@kylehuey.com>
On 14/09/16 22:01, Kyle Huey wrote:
> Xen advertises the underlying support for CPUID faulting but not does pass
> through writes to the relevant MSR, nor does it virtualize it, so it does
> not actually work. For now mask off the relevant bit on MSR_PLATFORM_INFO.
Could you clarify in the commit message that it is PV guests that are
affected.
> --- a/arch/x86/xen/enlighten.c
> +++ b/arch/x86/xen/enlighten.c
> @@ -1050,6 +1050,9 @@ static u64 xen_read_msr_safe(unsigned int msr, int *err)
> #endif
> val &= ~X2APIC_ENABLE;
> break;
> + case MSR_PLATFORM_INFO:
> + val &= ~CPUID_FAULTING_SUPPORT;
> + break;
> }
> return val;
> }
Acked-by: David Vrabel <david.vrabel@citrix.com>
David
next prev parent reply other threads:[~2016-09-15 10:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1473886902-17902-1-git-send-email-khuey@kylehuey.com>
2016-09-14 21:01 ` [PATCH v2 1/3] syscalls,x86 Expose arch_prctl on x86-32 Kyle Huey
2016-09-14 21:29 ` Dave Hansen
2016-09-14 21:35 ` Kyle Huey
2016-09-14 21:46 ` Dave Hansen
2016-09-14 21:56 ` Kyle Huey
2016-09-14 22:23 ` kbuild test robot
2016-09-15 0:01 ` kbuild test robot
2016-09-15 0:01 ` kbuild test robot
2016-09-15 1:14 ` Andy Lutomirski
2016-09-14 21:01 ` [PATCH v2 2/3] x86 Test and expose CPUID faulting capabilities in /proc/cpuinfo Kyle Huey
2016-09-14 21:35 ` Dave Hansen
2016-09-14 22:03 ` Kyle Huey
2016-09-15 1:17 ` Andy Lutomirski
2016-09-15 2:20 ` Kyle Huey
2016-09-15 20:38 ` H. Peter Anvin
2016-09-15 23:18 ` Andy Lutomirski
2016-09-15 10:07 ` David Vrabel
2016-09-15 10:05 ` David Vrabel [this message]
2016-09-15 10:25 ` [Xen-devel] " Jan Beulich
2016-09-15 19:11 ` Kyle Huey
2016-09-15 19:37 ` Andy Lutomirski
2016-09-15 23:36 ` Kyle Huey
2016-09-15 19:41 ` Boris Ostrovsky
2016-09-14 21:01 ` [PATCH v2 3/3] x86,arch_prctl Add ARCH_[GET|SET]_CPUID for controlling the CPUID instruction Kyle Huey
2016-09-15 1:29 ` Andy Lutomirski
2016-09-15 1:47 ` Kyle Huey
2016-09-15 1:54 ` Andy Lutomirski
2016-09-15 2:19 ` Kyle Huey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57DA724E.6090606@citrix.com \
--to=david.vrabel@citrix.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=aravind.gopalakrishnan@amd.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@suse.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=kristen@linux.intel.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=me@kylehuey.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=ray.huang@amd.com \
--cc=robert@ocallahan.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=vladimir_zapolskiy@mentor.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).