From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938383AbcISCvk (ORCPT ); Sun, 18 Sep 2016 22:51:40 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:40609 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755551AbcISCvd (ORCPT ); Sun, 18 Sep 2016 22:51:33 -0400 Subject: Re: [PATCH] perf, tools: Handle events including .c and .o To: Andi Kleen References: <1474160566-8955-1-git-send-email-andi@firstfloor.org> <57DE6A54.1000407@huawei.com> <20160918145603.GN3078@tassilo.jf.intel.com> CC: Andi Kleen , , , , From: "Wangnan (F)" Message-ID: <57DF5281.70905@huawei.com> Date: Mon, 19 Sep 2016 10:50:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160918145603.GN3078@tassilo.jf.intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.66.109] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.57DF528E.004B,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 562ca6a4f13d364c222346aecc58212a Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/9/18 22:56, Andi Kleen wrote: > On Sun, Sep 18, 2016 at 06:20:04PM +0800, Wangnan (F) wrote: >> >> On 2016/9/18 9:02, Andi Kleen wrote: >>> From: Andi Kleen >>> >>> This is a generic bug fix, but it helps with Sukadev's JSON event tree >>> where such events can happen. >>> >>> Any event inclduing a .c/.o/.bpf currently triggers BPF compilation or loading >>> and then an error. This can happen for some Intel JSON events, which cannot >>> be used. >>> >>> Fix the scanner to only match for .o or .c or .bpf at the end. >>> This will prevent loading multiple BPF scripts separated with comma, >>> but I assume this is acceptable. >>> >>> Cc: wangnan0@huawei.com >>> Cc: sukadev@linux.vnet.ibm.com >>> Signed-off-by: Andi Kleen >> I tested '.c' in middle of an event: >> >> # perf trace --event 'aaa.ccc' >> invalid or unsupported event: 'aaa.ccc' >> Run 'perf list' for a list of valid events >> ... >> >> It is not recongnized as a BPF source. >> >> So could you please provide an example to show how >> this potential bug breaks the parsing of new events? > This is with the upcoming JSON uncore events: > > $ perf stat -e '{unc_p_clockticks,unc_p_power_state_occupancy.cores_c0}' -a -I 1000 > ERROR: problems with path {unc_p_clockticks,unc_p_power_state_occupancy.c: No such file or directory > event syntax error: '{unc_p_clockticks,unc_p_power_state_occupancy.cores_c0}' > \___ Failed to load {unc_p_clockticks,unc_p_power_state_occupancy.c from source: Error when compiling BPF scriptlet > > (add -v to see detail) > Run 'perf list' for a list of valid events > > -Andi I see, and your patch solve problem like this. Tested-by: Wang Nan