From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751427AbcISOcR (ORCPT <rfc822;w@1wt.eu>);
        Mon, 19 Sep 2016 10:32:17 -0400
Received: from mail.southpole.se ([37.247.8.11]:36417 "EHLO mail.southpole.se"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751015AbcISOcQ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 19 Sep 2016 10:32:16 -0400
Subject: Re: [PATCH 7/7] openrisc: remove the redundant of_platform_populate
To: Stafford Horne <shorne@gmail.com>,
        Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
        Andrew Morton <akpm@linux-foundation.org>
References: <1474036985-20981-1-git-send-email-shorne@gmail.com>
 <1474036985-20981-8-git-send-email-shorne@gmail.com>
Cc: linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>
From: Jonas Bonn <jonas@southpole.se>
Message-ID: <57DFF6EC.2070806@southpole.se>
Date: Mon, 19 Sep 2016 16:32:12 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <1474036985-20981-8-git-send-email-shorne@gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-Assp-Version: 2.5.1(16177) on assp.southpole.se
X-Assp-ID: assp.southpole.se 95533-09794
X-Assp-Session: 7F0FD1D11AE8 (mail 1)
X-Assp-Client-SSL: yes
X-Assp-Server-TLS: yes
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/16/2016 04:43 PM, Stafford Horne wrote:
> From: Rob Herring <robh@kernel.org>
>
> The of_platform_populate call in the openrisc arch code is now redundant
> as the DT core provides a default call. Openrisc has a NULL match table
> which means only top level nodes with compatible strings will have
> devices creates. The default version will also descend nodes in the
> match table such as "simple-bus" which should be fine as openrisc
> doesn't have any of these (though it is preferred that memory-mapped
> peripherals be grouped under a bus node(s)).
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> Cc: Jonas Bonn <jonas@southpole.se>
> Signed-off-by: Stafford Horne <shorne@gmail.com>

Yes, this is fine, but trivial/generic stuff like this doesn't really 
need to go via the OpenRISC repo, anyway.

/Jonas

> ---
>   arch/openrisc/kernel/setup.c | 10 ----------
>   1 file changed, 10 deletions(-)
>
> diff --git a/arch/openrisc/kernel/setup.c b/arch/openrisc/kernel/setup.c
> index b4ed8b3..d2f78cf 100644
> --- a/arch/openrisc/kernel/setup.c
> +++ b/arch/openrisc/kernel/setup.c
> @@ -38,7 +38,6 @@
>   #include <linux/of.h>
>   #include <linux/memblock.h>
>   #include <linux/device.h>
> -#include <linux/of_platform.h>
>   
>   #include <asm/sections.h>
>   #include <asm/segment.h>
> @@ -219,15 +218,6 @@ void __init or32_early_setup(void *fdt)
>   	early_init_devtree(fdt);
>   }
>   
> -static int __init openrisc_device_probe(void)
> -{
> -	of_platform_populate(NULL, NULL, NULL, NULL);
> -
> -	return 0;
> -}
> -
> -device_initcall(openrisc_device_probe);
> -
>   static inline unsigned long extract_value_bits(unsigned long reg,
>   					       short bit_nr, short width)
>   {