LKML Archive on lore.kernel.org
 help / color / Atom feed
From: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
To: Rodolfo Giometti <giometti@enneenne.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Alexander Gordeev <lasaine@lvk.cs.msu.su>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH][RESEND] pps: kc: fix non-tickless system config dependency
Date: Wed, 21 Sep 2016 18:38:01 +0200
Message-ID: <57E2B769.50202@maciej.szmigiero.name> (raw)

CONFIG_NO_HZ currently only sets the default value
of dynticks config so if PPS kernel consumer needs
periodic timer ticks it should depend on
!CONFIG_NO_HZ_COMMON instead of !CONFIG_NO_HZ.

Otherwise it is possible to enable it even on
tickless system which has CONFIG_NO_HZ not set and
CONFIG_NO_HZ_IDLE (or CONFIG_NO_HZ_FULL) set.

Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
---
This is a resend without functional changes since previous
submission and resubmission weren't picked up.

@Rodolfo: Could you ack this, please?

 drivers/pps/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pps/Kconfig b/drivers/pps/Kconfig
index 7512e98e9311..564a51abeece 100644
--- a/drivers/pps/Kconfig
+++ b/drivers/pps/Kconfig
@@ -31,7 +31,7 @@ config PPS_DEBUG
 
 config NTP_PPS
 	bool "PPS kernel consumer support"
-	depends on !NO_HZ
+	depends on !NO_HZ_COMMON
 	help
 	  This option adds support for direct in-kernel time
 	  synchronization using an external PPS signal.

             reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-21 16:38 Maciej S. Szmigiero [this message]
2016-09-21 16:54 ` Rodolfo Giometti
  -- strict thread matches above, loose matches on Subject: below --
2016-07-02 20:30 Maciej S. Szmigiero

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57E2B769.50202@maciej.szmigiero.name \
    --to=mail@maciej.szmigiero.name \
    --cc=akpm@linux-foundation.org \
    --cc=giometti@enneenne.com \
    --cc=lasaine@lvk.cs.msu.su \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git