From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752553AbcJJNdI (ORCPT ); Mon, 10 Oct 2016 09:33:08 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:44768 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752247AbcJJNcL (ORCPT ); Mon, 10 Oct 2016 09:32:11 -0400 Subject: Re: [PATCH v7 3/6] perf annotate: Show raw form for jump instruction with indirect target To: Arnaldo Carvalho de Melo References: <1474472876-2706-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <1474472876-2706-4-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <20161005112701.GS7143@kernel.org> Cc: linux-kernel@vger.kernel.org, kim.phillips@arm.com, linuxppc-dev@lists.ozlabs.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, treeze.taeung@gmail.com, naveen.n.rao@linux.vnet.ibm.com, markus@trippelsdorf.de, namhyung@kernel.org, pawel.moll@arm.com, chris.ryder@arm.com, jolsa@kernel.org, mhiramat@kernel.org, Ravi Bangoria From: Ravi Bangoria Date: Mon, 10 Oct 2016 19:01:55 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20161005112701.GS7143@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16101013-0012-0000-0000-000010D90663 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005886; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000186; SDB=6.00766461; UDB=6.00366595; IPR=6.00542583; BA=6.00004799; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00012934; XFM=3.00000011; UTC=2016-10-10 13:32:07 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16101013-0013-0000-0000-0000462EAE68 Message-Id: <57FB984B.1090901@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-10_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1610100227 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 05 October 2016 04:57 PM, Arnaldo Carvalho de Melo wrote: > Em Wed, Sep 21, 2016 at 09:17:53PM +0530, Ravi Bangoria escreveu: >> For jump instructions that does not include target address as direct >> operand, use raw value for that. This is needed for certain powerpc > "use raw value" looks vague, as the example below makes is go from > using a value (ffffffffffffca2c) to no value at all, i.e. the output > looks backwards from what you describe, can you instead show the > original disassembled line from objdump, which I think is what you're > calling "raw value" in this case? Correct, I'm showing that only -- "original disassembled line from objdump". There is no direct operand with bctr. It uses content of register 'ctr' as target address. For example, objdump output: 100b8fd8: add r10,r9,r10 100b8fdc: mtctr r10 100b8fe0: bctr > - Arnaldo > >> jump instructions that use target address in a register (such as bctr, >> btar, ...). >> >> Before: >> ld r12,32088(r12) >> mtctr r12 >> v bctr ffffffffffffca2c >> std r2,24(r1) >> addis r12,r2,-1 >> >> After: >> ld r12,32088(r12) >> mtctr r12 >> v bctr >> std r2,24(r1) >> addis r12,r2,-1 >> >> Suggested-by: Michael Ellerman >> Signed-off-by: Ravi Bangoria >> --- >> Changes in v7: >> - Added example in description >> >> tools/perf/util/annotate.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c >> index 5aa72d9..1ccf26a 100644 >> --- a/tools/perf/util/annotate.c >> +++ b/tools/perf/util/annotate.c >> @@ -136,6 +136,9 @@ static int jump__parse(struct ins_operands *ops, struct map *map __maybe_unused) >> static int jump__scnprintf(struct ins *ins, char *bf, size_t size, >> struct ins_operands *ops) >> { >> + if (!ops->target.addr) >> + return ins__raw_scnprintf(ins, bf, size, ops); >> + >> return scnprintf(bf, size, "%-6.6s %" PRIx64, ins->name, ops->target.offset); >> } >> >> -- >> 2.5.5