From: Vladimir Zapolskiy <vz@mleia.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Linus Walleij <linus.walleij@linaro.org>,
Joachim Eastwood <manabian@gmail.com>
Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: lpc18xx: mark expected switch fall-throughs
Date: Fri, 17 Aug 2018 18:32:11 +0300 [thread overview]
Message-ID: <57a0c7c7-e2a2-3586-b683-f854120eeee7@mleia.com> (raw)
In-Reply-To: <20180815171035.GA17360@embeddedor.com>
On 08/15/2018 08:10 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 1292308 ("Missing break in switch")
> Addresses-Coverity-ID: 1292309 ("Missing break in switch")
> Addresses-Coverity-ID: 1309546 ("Missing break in switch")
> Addresses-Coverity-ID: 1357369 ("Missing break in switch")
> Addresses-Coverity-ID: 1357389 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/pinctrl/pinctrl-lpc18xx.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/pinctrl/pinctrl-lpc18xx.c b/drivers/pinctrl/pinctrl-lpc18xx.c
> index 190f17e..a14bc5e 100644
> --- a/drivers/pinctrl/pinctrl-lpc18xx.c
> +++ b/drivers/pinctrl/pinctrl-lpc18xx.c
> @@ -844,8 +844,11 @@ static int lpc18xx_pconf_get_pin(struct pinctrl_dev *pctldev, unsigned param,
> *arg = (reg & LPC18XX_SCU_PIN_EHD_MASK) >> LPC18XX_SCU_PIN_EHD_POS;
> switch (*arg) {
> case 3: *arg += 5;
> + /* fall through */
> case 2: *arg += 5;
> + /* fall through */
> case 1: *arg += 3;
> + /* fall through */
> case 0: *arg += 4;
> }
> break;
> @@ -1060,8 +1063,11 @@ static int lpc18xx_pconf_set_pin(struct pinctrl_dev *pctldev, unsigned param,
>
> switch (param_val) {
> case 20: param_val -= 5;
> + /* fall through */
> case 14: param_val -= 5;
> + /* fall through */
> case 8: param_val -= 3;
> + /* fall through */
> case 4: param_val -= 4;
> break;
> default:
>
The code snippets are about a mind-blowing hyper-optimization, but I took
it as a chance to verify the correctness, and there are no issues found.
Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>
--
Best wishes,
Vladimir
next prev parent reply other threads:[~2018-08-17 15:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 17:10 [PATCH] pinctrl: lpc18xx: mark expected switch fall-throughs Gustavo A. R. Silva
2018-08-17 15:32 ` Vladimir Zapolskiy [this message]
2018-08-29 11:47 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57a0c7c7-e2a2-3586-b683-f854120eeee7@mleia.com \
--to=vz@mleia.com \
--cc=gustavo@embeddedor.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manabian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).