From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966238AbcIWNrF (ORCPT ); Fri, 23 Sep 2016 09:47:05 -0400 Received: from mout.web.de ([212.227.15.3]:51483 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1034521AbcIWNrA (ORCPT ); Fri, 23 Sep 2016 09:47:00 -0400 Subject: Re: GPU-DRM-TTM: Fine-tuning for several function implementations To: Dan Carpenter References: <566ABCD9.1060404@users.sourceforge.net> <4d34446f-05ad-c3ce-5d33-8fb4f25af25c@users.sourceforge.net> <05418fb1-ad66-aba3-bd8c-f6b684a83279@users.sourceforge.net> <20160923125525.GR13620@mwanda> Cc: =?UTF-8?Q?Christian_K=c3=b6nig?= , dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , Emil Velikov , Julia Lawall , kernel-janitors@vger.kernel.org, LKML From: SF Markus Elfring Message-ID: <57a602e8-ba38-6cbb-078d-ac562b024441@users.sourceforge.net> Date: Fri, 23 Sep 2016 15:46:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20160923125525.GR13620@mwanda> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:ORQOhb3pqFUVtJfSxK3rhaNHwKEtizQ3rzCEzbosHHPm+/PqVgi F3pC95QNhcqgP2dTAk7/QvnHv/GlWBB5sj/U2Q5BqLH0x9b8a3e7B/iv+7NKE4jVkvJ+w19 lmlahy3sA4BHFXJqaT555L1AIhasviGKUAxXYPa8Nt6Jy19Tx5tR8OseC3Nz3dNNcUU1+VY zIC+umC+aKQM0xLnQKNdg== X-UI-Out-Filterresults: notjunk:1;V01:K0:UrVVxsmMMfY=:gIp68iFjfUeKvrT5/IqqQE BhQUGGSTngHEy/4EQER5m+jFfYFODg2ZFp2VB0LbxuhupgWlF7XxXdh6FXY0RhGeqi666eYYU PTH2PC0wWSkPAa/8MqkGseJl/NG78av5tiabTUvUI1UhLNpjGzOYPk6C46JkklRXHF9sBut/l IMH6Cb2M27QaLWSWQCfRWNWA0oVeLuD2Q/IZpFg0vI5c39VTFQP6slLXEBcj3K1/bWvkF0kL+ NZpJp/lXKwre82bjlCH8qRDQEcLQL14x+iEkajt58JTtEevja8ae7NA51+kRlOdSUQB+olsdr 3faZ5tbSjqBXr1HFKIxT38NM7ngF7MO7wu7IrwinGL3hHg7BKq4TL5iIXZAjeCxGSHgDHpsmA 8M84f5NXoYe1pfqgQTvaDhCrnufGKIb4JIxwra8UXIu5GzYdInf1E2yXUqSYwqZnzYOfvet+j oz9Ov0MJUafrrbG+JWuNtpdH+oyvONDBDsHrtahIxDimK0A5rFXjCqWSb7uG0X3QChVT07IMW NBhFQS9FvjhK2JFqqjLS/OKd5HvF0keBpN7tgvvJ9SXJ3d7JCt67KLaytrsqPbPMm/3OKTIXT kpLLIlNSr/+2X77NXrZOw6H1Ik+p3NkYHjVtK+Ig/IMld5cAj64dh/KC2OJmvgm508lemocuT 9D8ddSlY+2HBh2lG6rssXV4xlwEUfEGKdALTXEdmdKr1ufJN11ywvRucjqAuhCOEI08HYOMBT gnee0P4K5Ae7d3ZNgx49J7zXD1Uxza6SSGPY23xXlHZjiIGdp5V5gux7nchvEugB+Ab/5UqOn c+o9lTx Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Do other identifiers fit better to a specification from the document "CodingStyle" >> like the following? >> >> "… >> Choose label names which say what the goto does or why the goto exists. >> …" >> >> >> Does this wording need any more adjustments? > > No. I have got an other impression. The terse description can trigger disagreements about the "what" and "why", can't it? > I wrote that and "restart" seems like a pretty clear name to me. This identifier might be good enough to some degree. I imagined that it would become better by the addition of a bit of information from the jump target. > I never wrote that you should harrass people with your nonsense patches. This is true in principle. But your adjustment for the document "CodingStyle" supported also a reconsideration of the corresponding identifier selection. Some developers disagreed with a proposed renaming while others reacted in a positive way. > In fact, I have asked you over and over again to stop. This happened under different software update contexts occasionally. Regards, Markus