From: yuanjunqing <yuanjunqing66@163.com>
To: tsbogend@alpha.franken.de
Cc: paulburton@kernel.org, chenhc@lemote.com,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
liulichao@loongson.cn
Subject: Re: [PATCH] MIPS: Fix IRQ tracing when call handle_fpe() and handle_msa_fpe()
Date: Thu, 28 May 2020 20:37:28 +0800 [thread overview]
Message-ID: <57a8191b-1c64-9a5e-7935-050263d715fb@163.com> (raw)
In-Reply-To: <20200528123505.4219-1-yuanjunqing66@163.com>
sorry!
在 2020/5/28 下午8:35, YuanJunQing 写道:
> Register "a1" is unsaved in this function,
> when CONFIG_TRACE_IRQFLAGS is enabled,
> the TRACE_IRQS_OFF macro will call trace_hardirqs_off(),
> and this may change register "a1".
> The changed register "a1" as argument will be send
> to do_fpe() and do_msa_fpe().
>
> Signed-off-by: YuanJunQing <yuanjunqing66@163.com>
> ---
> arch/mips/kernel/genex.S | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/mips/kernel/genex.S b/arch/mips/kernel/genex.S
> index 8236fb291e3f..a1b966f3578e 100644
> --- a/arch/mips/kernel/genex.S
> +++ b/arch/mips/kernel/genex.S
> @@ -476,20 +476,20 @@ NESTED(nmi_handler, PT_SIZE, sp)
> .endm
>
> .macro __build_clear_fpe
> + CLI
> + TRACE_IRQS_OFF
> .set push
> /* gas fails to assemble cfc1 for some archs (octeon).*/ \
> .set mips1
> SET_HARDFLOAT
> cfc1 a1, fcr31
> .set pop
> - CLI
> - TRACE_IRQS_OFF
> .endm
>
> .macro __build_clear_msa_fpe
> - _cfcmsa a1, MSA_CSR
> CLI
> TRACE_IRQS_OFF
> + _cfcmsa a1, MSA_CSR
> .endm
>
> .macro __build_clear_ade
next prev parent reply other threads:[~2020-05-28 12:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 12:35 [PATCH] MIPS: Fix IRQ tracing when call handle_fpe() and handle_msa_fpe() YuanJunQing
2020-05-28 12:37 ` yuanjunqing [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-27 6:11 YuanJunQing
2020-05-27 11:35 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57a8191b-1c64-9a5e-7935-050263d715fb@163.com \
--to=yuanjunqing66@163.com \
--cc=chenhc@lemote.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=liulichao@loongson.cn \
--cc=paulburton@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).