linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lyude Paul <lyude@redhat.com>
To: Aaron Ma <aaron.ma@canonical.com>,
	jani.nikula@intel.com, airlied@linux.ie,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	daniel@ffwll.ch, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/i915: Force DPCD backlight mode for Samsung 16727 panel
Date: Wed, 19 May 2021 12:27:03 -0400	[thread overview]
Message-ID: <57b373372cb64e8a48d12e033a23e7711332b0ec.camel@redhat.com> (raw)
In-Reply-To: <20210519095305.47133-1-aaron.ma@canonical.com>

Seems reasonable to me:

Reviewed-by: Lyude Paul <lyude@redhat.com>

On Wed, 2021-05-19 at 17:53 +0800, Aaron Ma wrote:
> Another Samsung OLED panel needs DPCD to get control of backlight.
> Kernel 5.12+ support the backlight via:
> commit: <4a8d79901d5b> ("drm/i915/dp: Enable Intel's HDR backlight interface
> (only SDR for now)")
> Only make backlight work on lower versions of kernel.
> 
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3474
> Cc: stable@vger.kernel.org # 5.11-
> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
> ---
>  drivers/gpu/drm/drm_dp_helper.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> index 5bd0934004e3..7b91d8a76cd6 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -1960,6 +1960,7 @@ static const struct edid_quirk edid_quirk_list[] = {
>         { MFG(0x4d, 0x10), PROD_ID(0xe6, 0x14),
> BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
>         { MFG(0x4c, 0x83), PROD_ID(0x47, 0x41),
> BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
>         { MFG(0x09, 0xe5), PROD_ID(0xde, 0x08),
> BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
> +       { MFG(0x4c, 0x83), PROD_ID(0x57, 0x41),
> BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
>  };
>  
>  #undef MFG

-- 
Sincerely,
   Lyude Paul (she/her)
   Software Engineer at Red Hat
   
Note: I deal with a lot of emails and have a lot of bugs on my plate. If you've
asked me a question, are waiting for a review/merge on a patch, etc. and I
haven't responded in a while, please feel free to send me another email to check
on my status. I don't bite!


  reply	other threads:[~2021-05-19 16:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-19  9:53 Aaron Ma
2021-05-19 16:27 ` Lyude Paul [this message]
2021-06-30  4:29   ` Aaron Ma
2021-06-30  9:04     ` Greg KH
2021-06-30  9:37       ` [RESEND][PATCH] " Aaron Ma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57b373372cb64e8a48d12e033a23e7711332b0ec.camel@redhat.com \
    --to=lyude@redhat.com \
    --cc=aaron.ma@canonical.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --subject='Re: [PATCH] drm/i915: Force DPCD backlight mode for Samsung 16727 panel' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).