From: Peng Fan <peng.fan@oss.nxp.com>
To: Matti Vaittinen <mazziesaccount@gmail.com>,
Tim Harvey <tharvey@gateworks.com>
Cc: Marek Vasut <marex@denx.de>, Peng Fan <peng.fan@nxp.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Shawn Guo <shawnguo@kernel.org>, dl-linux-imx <linux-imx@nxp.com>,
Michael Turquette <mturquette@baylibre.com>
Subject: Re: BD71847 clk driver disables clk-32k-out causing RTC/WDT failure
Date: Tue, 13 Sep 2022 10:27:56 +0800 [thread overview]
Message-ID: <57b89f2e-dc70-9890-143c-f6da5aaba015@oss.nxp.com> (raw)
In-Reply-To: <e8279305-6bad-4029-4436-b48a4a8d43e9@gmail.com>
On 9/13/2022 4:40 AM, Matti Vaittinen wrote:
> On 9/12/22 20:15, Tim Harvey wrote:
>> On Mon, Sep 12, 2022 at 12:40 AM Peng Fan <peng.fan@oss.nxp.com> wrote:
>
> //snip
>
>>>
>>> After a thought, maybe an easier way is to add a optional property
>>> xxx,32k-always-on to the pmic node/driver.
>>>
>
> Yes, that would be easy. Yet, creating a driver specific DT-property
> feels a tad wrong. I don't think the BD718xx is in any way special so it
> should not need such a vendor specific property. It might be better to
> find more generic solution.
I am not sure, even if saying always-on-clocks are accepted, the
property still needs to wrote into the BD718xx node, because BD718xx
itself serves as a clock provider.
Regards,
Peng.
>
>> Is there simply a way to add the clk to the snvs_rtc and the wdog dt
>> nodes so they have a use count and don't get disabled?
>
> To me that does sound like the right thing to do. If we have a consumer
> which requires the clock, then describing this dependency in DT sounds
> like a correct approach - assuming this keeps the clock enabled without
> a race between instantiating the PMIC and finding the clock consumers.
>
> Finally, if adding the consumers does not help, and if there will be no
> consensus regarding the generic property - then I think it's better to
> have a vendor specific property (as Peng suggested) than it is having
> the boards broken. Eg, if all else fails and if there is a buy-in for
> the vendor specific propety from Rob and Stephen - then I can also live
> with it (even if it sure significantly decreases my happiness level :p)
>
> Yours,
> -- Matti
>
next prev parent reply other threads:[~2022-09-13 2:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 22:23 BD71847 clk driver disables clk-32k-out causing RTC/WDT failure Tim Harvey
2022-09-02 4:14 ` Matti Vaittinen
2022-09-08 16:00 ` Tim Harvey
2022-09-08 16:55 ` Marek Vasut
2022-09-08 19:25 ` Tim Harvey
2022-09-08 20:39 ` Marek Vasut
2022-09-09 2:06 ` Peng Fan
2022-09-09 2:35 ` Marek Vasut
2022-09-09 5:06 ` Matti Vaittinen
2022-09-12 7:40 ` Peng Fan
2022-09-12 17:15 ` Tim Harvey
2022-09-12 20:40 ` Matti Vaittinen
2022-09-13 2:27 ` Peng Fan [this message]
2022-09-13 15:21 ` Sebastian Reichel
2022-09-13 17:01 ` Matti Vaittinen
2022-09-13 2:30 ` Peng Fan
2022-09-09 6:56 ` Peng Fan
2022-09-09 7:01 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57b89f2e-dc70-9890-143c-f6da5aaba015@oss.nxp.com \
--to=peng.fan@oss.nxp.com \
--cc=festevam@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=mazziesaccount@gmail.com \
--cc=mturquette@baylibre.com \
--cc=peng.fan@nxp.com \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).