From: Maxim Levitsky <mlevitsk@redhat.com>
To: Chao Gao <chao.gao@intel.com>, Sean Christopherson <seanjc@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] KVM: x86: Trace all APICv inhibit changes and capture overall status
Date: Tue, 15 Mar 2022 16:48:12 +0200 [thread overview]
Message-ID: <57c2d5d64f9d65e442744fa8b7f188ed3fd37c1c.camel@redhat.com> (raw)
In-Reply-To: <20220315144249.GA5496@gao-cwp>
On Tue, 2022-03-15 at 22:42 +0800, Chao Gao wrote:
> On Fri, Mar 11, 2022 at 04:35:17AM +0000, Sean Christopherson wrote:
> > --- a/arch/x86/kvm/x86.c
> > +++ b/arch/x86/kvm/x86.c
> > @@ -9053,15 +9053,29 @@ bool kvm_apicv_activated(struct kvm *kvm)
> > }
> > EXPORT_SYMBOL_GPL(kvm_apicv_activated);
> >
> > +
>
> stray newline.
>
> > +static void set_or_clear_apicv_inhibit(unsigned long *inhibits,
> > + enum kvm_apicv_inhibit reason, bool set)
> > +{
> > + if (set)
> > + __set_bit(reason, inhibits);
> > + else
> > + __clear_bit(reason, inhibits);
> > +
> > + trace_kvm_apicv_inhibit_changed(reason, set, *inhibits);
>
> Note that some calls may not toggle any bit. Do you want to log them?
> I am afraid that a VM with many vCPUs may get a lot of traces that actually
> doesn't change inhibits.
I also think so.
Best regards,
Maxim Levitsky
>
> Anyway, this series looks good to me.
>
next prev parent reply other threads:[~2022-03-15 14:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 4:35 [PATCH 0/3] KVM: x86: APICv inhibition cleanups Sean Christopherson
2022-03-11 4:35 ` [PATCH 1/3] KVM: x86: Make APICv inihibit reasons an enum and cleanup naming Sean Christopherson
2022-03-11 4:35 ` [PATCH 2/3] KVM: x86: Add wrappers for setting/clearing APICv inhibits Sean Christopherson
2022-03-11 4:35 ` [PATCH 3/3] KVM: x86: Trace all APICv inhibit changes and capture overall status Sean Christopherson
2022-03-15 14:42 ` Chao Gao
2022-03-15 14:48 ` Maxim Levitsky [this message]
2022-03-15 21:12 ` Paolo Bonzini
2022-03-15 21:38 ` [PATCH 0/3] KVM: x86: APICv inhibition cleanups Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57c2d5d64f9d65e442744fa8b7f188ed3fd37c1c.camel@redhat.com \
--to=mlevitsk@redhat.com \
--cc=chao.gao@intel.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).