linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frank Rowand <frowand.list@gmail.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Rob Herring <robh@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	DTML <devicetree@vger.kernel.org>
Subject: Re: [PATCH] libfdt: reduce the number of headers included from libfdt_env.h
Date: Thu, 17 Oct 2019 12:23:37 -0500	[thread overview]
Message-ID: <57c33deb-651b-3357-0e5a-95379be8a965@gmail.com> (raw)
In-Reply-To: <CAK7LNAS=9yGqMQ9eoM4L0hhvuFRYhg6S4i6J3Ou9vcB1Npj4BQ@mail.gmail.com>

On 10/16/2019 06:01, Masahiro Yamada wrote:
> Hi Andrew,
> 
> Could you pick up this to akpm tree?
> https://lore.kernel.org/patchwork/patch/1089856/
> 
> I believe this is correct, and a good clean-up.
> 
> I pinged the DT maintainers, but they did not respond.

Sorry for the delay in responding.

libfdt_env.h is imported from an upstream project, using
the script scripts/dtc/update-dtc-source.sh.  Inside
that script are some 'sed' commands to modify the
imported files before committing them.  Please add
a sed command to make the change that the proposed
patch makes.

Thanks,

Frank

> 
> Thanks.
> 
> 
> 
> 
> On Mon, Aug 19, 2019 at 1:36 PM Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
>>
>> On Thu, Aug 1, 2019 at 11:30 AM Masahiro Yamada
>> <yamada.masahiro@socionext.com> wrote:
>>>
>>> On Tue, Jun 18, 2019 at 1:21 AM Masahiro Yamada
>>> <yamada.masahiro@socionext.com> wrote:
>>>>
>>>> Currently, libfdt_env.h includes <linux/kernel.h> just for INT_MAX.
>>>>
>>>> <linux/kernel.h> pulls in a lots of broat.
>>>>
>>>> Thanks to commit 54d50897d544 ("linux/kernel.h: split *_MAX and *_MIN
>>>> macros into <linux/limits.h>"), <linux/kernel.h> can be replaced with
>>>> <linux/limits.h>.
>>>>
>>>> This saves including dozens of headers.
>>>>
>>>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>>>> ---
>>>
>>> ping?
>>
>> ping x2.
>>
>>
>>
>>
>>>
>>>
>>>>  include/linux/libfdt_env.h | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/include/linux/libfdt_env.h b/include/linux/libfdt_env.h
>>>> index edb0f0c30904..2231eb855e8f 100644
>>>> --- a/include/linux/libfdt_env.h
>>>> +++ b/include/linux/libfdt_env.h
>>>> @@ -2,7 +2,7 @@
>>>>  #ifndef LIBFDT_ENV_H
>>>>  #define LIBFDT_ENV_H
>>>>
>>>> -#include <linux/kernel.h>      /* For INT_MAX */
>>>> +#include <linux/limits.h>      /* For INT_MAX */
>>>>  #include <linux/string.h>
>>>>
>>>>  #include <asm/byteorder.h>
>>>> --
>>>> 2.17.1
>>>>
>>>
>>>
>>> --
>>> Best Regards
>>> Masahiro Yamada
>>
>>
>>
>> --
>> Best Regards
>> Masahiro Yamada
> 
> 
> 


      parent reply	other threads:[~2019-10-17 17:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-17 16:21 [PATCH] libfdt: reduce the number of headers included from libfdt_env.h Masahiro Yamada
2019-08-01  2:30 ` Masahiro Yamada
2019-08-19  4:36   ` Masahiro Yamada
2019-10-16 11:01     ` Masahiro Yamada
2019-10-17 16:34       ` Rob Herring
2019-10-17 17:25         ` Frank Rowand
2019-10-17 17:52           ` Rob Herring
2019-10-17 18:46             ` Frank Rowand
2019-10-17 17:23       ` Frank Rowand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57c33deb-651b-3357-0e5a-95379be8a965@gmail.com \
    --to=frowand.list@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).