From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
"liavr@mellanox.com" <liavr@mellanox.com>
Cc: Cupertino Miranda <Cupertino.Miranda@synopsys.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"eladkan@mellanox.com" <eladkan@mellanox.com>,
"noamca@mellanox.com" <noamca@mellanox.com>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>
Subject: Re: [PATCH] ARC: Change ld.as instruction to regular ld.
Date: Thu, 25 Aug 2016 10:40:17 -0700 [thread overview]
Message-ID: <57ce386e-d8f1-90f0-fb7c-c1f7b4589fa9@synopsys.com> (raw)
In-Reply-To: <1472126602.2600.14.camel@synopsys.com>
On 08/25/2016 05:05 AM, Alexey Brodkin wrote:
> Hi Liav,
>
> On Wed, 2016-08-17 at 09:23 +0300, Liav Rehana wrote:
>> From: Liav Rehana <liavr@mellanox.com>
>>
>> User mode callee regs are explicitly collected before signal delivery
>> or breakpoint trap. r25 is special for kernel as it serves as task
>> pointer, so user mode value is clobbered very early. It is saved in
>> pt_regs where generally only scratch (caller saved) res are saved.
>> The code to access the corresponding pt_regs location had a subtle bug
>> as it was using load/store with scaling of offset, whereas the offset
>> was already byte wise correct. So fix this by replacing LD.AS with a
>> standard LD
>>
>> Signed-off-by: Liav Rehana <liavr@mellanox.com>
> That nice patch really fixes quite annoying issue when r25 got
> printed improperly in gdb!
>
> So
>
> Tested-by: Alexey Brodkin <abrodkin@synopsys.com>
Indeed this becomes even more important given that r25 is Thread pointer regs in
ARC ABI !
This patch is already merged upstream by Linus.
Thx,
-Vineet
next prev parent reply other threads:[~2016-08-25 17:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 6:23 [PATCH] ARC: Change ld.as instruction to regular ld Liav Rehana
2016-08-17 17:16 ` Vineet Gupta
2016-08-25 12:05 ` Alexey Brodkin
2016-08-25 17:40 ` Vineet Gupta [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-08-16 7:55 Liav Rehana
2016-08-16 13:15 ` Alexey Brodkin
2016-08-16 15:47 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57ce386e-d8f1-90f0-fb7c-c1f7b4589fa9@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Cupertino.Miranda@synopsys.com \
--cc=eladkan@mellanox.com \
--cc=liavr@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=noamca@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).