From: Jon Hunter <jonathanh@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-tegra@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH V2 1/5] dt-bindings: usb: xhci-tegra: Add power-domain details
Date: Fri, 12 Oct 2018 08:36:11 +0100 [thread overview]
Message-ID: <57da6e07-1f21-5ebd-7708-c606ee33e8fa@nvidia.com> (raw)
In-Reply-To: <20181011164952.GC7393@ulmo>
On 11/10/18 17:49, Thierry Reding wrote:
> On Fri, Sep 28, 2018 at 03:11:46PM +0100, Jon Hunter wrote:
>> Add details for power-domains to the Tegra xHCI bindings so that
>> generic power-domains can be used for inconjunction with the xHCI
>> driver.
>>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>> ---
>> Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt b/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt
>> index 3eee9e505400..4156c3e181c5 100644
>> --- a/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt
>> +++ b/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt
>> @@ -59,6 +59,14 @@ For Tegra210:
>> - avdd-pll-uerefe-supply: PLLE reference PLL power supply. Must supply 1.05 V.
>> - dvdd-pex-pll-supply: PCIe/USB3 PLL power supply. Must supply 1.05 V.
>> - hvdd-pex-pll-e-supply: High-voltage PLLE power supply. Must supply 1.8 V.
>> +- power-domains: A list of PM domain specifiers that reference each power-domain
>> + used by the xHCI controller. This list must comprise of a specifier for the
>> + XUSBA and XUSBC power-domains. See ../power/power_domain.txt and
>> + ../arm/tegra/nvidia,tegra20-pmc.txt for details.
>> +- power-domain-names: A list of names that represent each of the specifiers in
>> + the 'power-domains' property. Must include 'xusb_ss' and 'xusb_host' which
>
> Total bike-shed comment: maybe call these "superspeed" and "host" or
> something. The xusb_ prefix is kind of redundent because of the context.
> On the other hand, those are the names by which the power partitions are
> referred to, so either way:
I choose these names because they align with what we already have for
clocks ...
- clock-names: Must include the following entries:
- xusb_host
- xusb_host_src
- xusb_falcon_src
- xusb_ss
- xusb_ss_src
- xusb_ss_div2
- xusb_hs_src
- xusb_fs_src
- pll_u_480m
- clk_m
- pll_e
However, I don't have a strong preference.
> Acked-by: Thierry Reding <treding@nvidia.com>
Thanks!
Jon
--
nvpublic
next prev parent reply other threads:[~2018-10-12 7:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 14:11 [PATCH V2 0/5] Tegra xHCI genpd support Jon Hunter
2018-09-28 14:11 ` [PATCH V2 1/5] dt-bindings: usb: xhci-tegra: Add power-domain details Jon Hunter
2018-10-11 16:49 ` Thierry Reding
2018-10-12 7:36 ` Jon Hunter [this message]
2018-10-12 19:38 ` Rob Herring
2018-09-28 14:11 ` [PATCH V2 2/5] usb: xhci: tegra: Power-off power-domains on removal Jon Hunter
2018-10-11 16:48 ` Thierry Reding
2018-09-28 14:11 ` [PATCH V2 3/5] usb: xhci: tegra: Add genpd support Jon Hunter
2018-10-03 9:52 ` Ulf Hansson
2018-10-03 13:44 ` Jon Hunter
2018-10-11 16:47 ` Thierry Reding
2018-10-12 8:41 ` Jon Hunter
2018-10-12 10:27 ` Thierry Reding
2018-10-15 13:29 ` Ulf Hansson
2018-09-28 14:11 ` [PATCH V2 4/5] soc/tegra: pmc: Don't power-up XUSB power-domains Jon Hunter
2018-10-11 16:50 ` Thierry Reding
2018-09-28 14:11 ` [PATCH V2 5/5] arm64: dts: tegra210: Add power-domains for xHCI Jon Hunter
2018-10-11 16:51 ` Thierry Reding
2018-10-15 12:40 ` [PATCH V2 0/5] Tegra xHCI genpd support Jon Hunter
2018-10-16 11:00 ` Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57da6e07-1f21-5ebd-7708-c606ee33e8fa@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathias.nyman@intel.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).