From: Dan Murphy <dmurphy@ti.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: <robh+dt@kernel.org>, <jacek.anaszewski@gmail.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-leds@vger.kernel.org>, <lee.jones@linaro.org>,
<tony@atomide.com>
Subject: Re: [PATCH v4 5/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3633
Date: Thu, 25 Oct 2018 13:01:52 -0500 [thread overview]
Message-ID: <57f73b8f-3eab-642d-5b4e-c7c6c890006b@ti.com> (raw)
In-Reply-To: <20181024092328.GD24997@amd>
Pavel
On 10/24/2018 04:23 AM, Pavel Machek wrote:
> On Tue 2018-10-23 12:06:21, Dan Murphy wrote:
>> The LM3633 is a single function LED driver. The single function LED
>> driver needs to reside in the LED directory as a dedicated LED driver
>> and not as a MFD device. The device does have common brightness and ramp
>> features and those can be accomodated by a TI LMU framework.
>>
>> The LM3633 dt binding needs to be moved from the ti-lmu.txt and a dedicated
>> LED dt binding needs to be added. The new LM3633 LED dt binding will then
>> reside in the Documentation/devicetree/bindings/leds directory and follow the
>> current LED and general bindings guidelines.
>
> What?
>
>> .../devicetree/bindings/leds/leds-lm3633.txt | 102 ++++++++++++++++++
>> .../devicetree/bindings/mfd/ti-lmu.txt | 48 ---------
>> 2 files changed, 102 insertions(+), 48 deletions(-)
>> create mode 100644
>> Documentation/devicetree/bindings/leds/leds-lm3633.txt
>
>> index 920f910be4e9..573e88578d3d 100644
>> --- a/Documentation/devicetree/bindings/mfd/ti-lmu.txt
>> +++ b/Documentation/devicetree/bindings/mfd/ti-lmu.txt
>> @@ -7,7 +7,6 @@ TI LMU driver supports lighting devices below.
>> LM3532 Backlight
>> LM3631 Backlight and regulator
>> LM3632 Backlight and regulator
>> - LM3633 Backlight, LED and fault monitor
>> LM3695 Backlight
>
> Are you seriously proposing to take one binding and split it into 6
> copy&pasted ones?
No that is not what I am proposing. And never have. I support keeping the MFD
devices in the MFD directory and only pulling out the single function devices as we have
debated over and over again.
>
> That's not the way we do development. NAK.
>
> We don't want to have copy & pasted code. We also don't want to have
> copy & pasted bindings. Nor changelogs, for that matter.
>
Change was copy and pasted don't know why I need to rephrase the same exact
change only for a different part but I can modify it.
I do see what I can update here. As you said I will fix up the ti-lmu binding in
such a way that the dedicated LED driver bindings point to the common binding for the TI-LMU
framework.
Dan
> Thank you,
> Pavel
>
--
------------------
Dan Murphy
next prev parent reply other threads:[~2018-10-25 18:02 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 17:06 [PATCH v4 1/7] leds: add TI LMU backlight driver Dan Murphy
2018-10-23 17:06 ` [PATCH v4 2/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3697 Dan Murphy
2018-10-24 9:04 ` Pavel Machek
2018-10-24 12:07 ` Dan Murphy
2018-10-24 13:43 ` Pavel Machek
2018-10-24 14:54 ` Rob Herring
2018-10-25 18:07 ` Dan Murphy
2018-10-25 18:27 ` Jacek Anaszewski
2018-10-25 18:32 ` Dan Murphy
2018-10-25 19:54 ` Rob Herring
2018-10-26 8:30 ` Pavel Machek
2018-10-26 8:37 ` Pavel Machek
2018-10-30 13:40 ` Dan Murphy
2019-03-02 23:07 ` Pavel Machek
2019-03-04 19:14 ` Dan Murphy
2018-10-24 14:49 ` Rob Herring
2018-10-25 17:56 ` Dan Murphy
2018-10-23 17:06 ` [PATCH v4 3/7] mfd: ti-lmu: Remove support for LM3697 Dan Murphy
2018-10-23 17:06 ` [PATCH v4 4/7] leds: lm3697: Introduce the lm3697 driver Dan Murphy
2018-10-23 17:06 ` [PATCH v4 5/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3633 Dan Murphy
2018-10-24 9:23 ` Pavel Machek
2018-10-24 14:35 ` Rob Herring
2018-10-24 18:38 ` Pavel Machek
2018-10-24 21:50 ` Rob Herring
2018-10-25 18:01 ` Dan Murphy [this message]
2018-10-23 17:06 ` [PATCH v4 6/7] mfd: ti-lmu: Remove support for LM3633 Dan Murphy
2018-10-23 17:06 ` [PATCH v4 7/7] leds: lm3633: Introduce the lm3633 driver Dan Murphy
2018-10-24 9:14 ` [PATCH v4 1/7] leds: add TI LMU backlight driver Pavel Machek
2018-10-24 12:27 ` Dan Murphy
2018-10-24 13:17 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57f73b8f-3eab-642d-5b4e-c7c6c890006b@ti.com \
--to=dmurphy@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).