From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S941414AbcJXRJf (ORCPT <rfc822;w@1wt.eu>);
        Mon, 24 Oct 2016 13:09:35 -0400
Received: from mga07.intel.com ([134.134.136.100]:23528 "EHLO mga07.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S933644AbcJXRJd (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 24 Oct 2016 13:09:33 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,542,1473145200"; 
   d="scan'208";a="1049345784"
Subject: Re: [RFC 1/8] mm: Define coherent device memory node
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
References: <1477283517-2504-1-git-send-email-khandual@linux.vnet.ibm.com>
 <1477283517-2504-2-git-send-email-khandual@linux.vnet.ibm.com>
Cc: mhocko@suse.com, js1304@gmail.com, vbabka@suse.cz, mgorman@suse.de,
        minchan@kernel.org, akpm@linux-foundation.org,
        aneesh.kumar@linux.vnet.ibm.com, bsingharora@gmail.com
From: Dave Hansen <dave.hansen@intel.com>
Message-ID: <580E4043.4090200@intel.com>
Date: Mon, 24 Oct 2016 10:09:23 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <1477283517-2504-2-git-send-email-khandual@linux.vnet.ibm.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> +#ifdef CONFIG_COHERENT_DEVICE
> +#define node_cdm(nid)          (NODE_DATA(nid)->coherent_device)
> +#define set_cdm_isolation(nid) (node_cdm(nid) = 1)
> +#define clr_cdm_isolation(nid) (node_cdm(nid) = 0)
> +#define isolated_cdm_node(nid) (node_cdm(nid) == 1)
> +#else
> +#define set_cdm_isolation(nid) ()
> +#define clr_cdm_isolation(nid) ()
> +#define isolated_cdm_node(nid) (0)
> +#endif

FWIW, I think adding all this "cdm" gunk in the names is probably a bad
thing.

I can think of other memory types that are coherent, but
non-device-based that might want behavior like this.