From: Christopher Heiny <Cheiny@synaptics.com>
To: Aaron Ma <aaron.ma@canonical.com>,
"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Duggan <aduggan@synaptics.com>,
"benjamin.tissoires@redhat.com" <benjamin.tissoires@redhat.com>
Subject: Re: [PATCH 1/2] Input: synaptics-rmi4 - clear irqs before set irqs
Date: Tue, 4 Jun 2019 05:19:59 +0000 [thread overview]
Message-ID: <580b73847333fa1866caaccc959bf8735b4f7524.camel@synaptics.com> (raw)
In-Reply-To: <2995b27a-9ec8-eebe-78b6-2d3bf5098af8@canonical.com>
On Tue, 2019-06-04 at 10:45 +0800, Aaron Ma wrote:
> Hi Christopher:
>
> Have got time to review these 2 patches?
> Users reported it works fine since I sent out this patch.
Hi Aaron,
I've been poking around with this off and on. Unfortunately, more off
than on :-( but here's my current take:
rmi_driver_set_irq_bits() isn't going to be called all that often, and
it's not going to be called at all during normal operation, which is
where the most serious problem would occur.
I haven't entirely convinced myself that there couldn't be a problem
during repeated spontaneous device resets (for example, due to ESD, a
dodgy charger, or firmware bug, among other things). On the other
hand, all the scenarios I have come up with are both unlikely and so
contrived that the system is probably hosed regardless of what we do in
the driver.
Given that, I'm willing to accept the patch as is.
Cheers,
Chris
>
> Thanks,
> Aaron
>
> On 4/3/19 9:58 PM, Aaron Ma wrote:
> > Sure, take your time, if you have any questions let me know please.
> >
> > Thanks,
> > Aaron
next prev parent reply other threads:[~2019-06-04 5:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 16:41 [PATCH 1/2] Input: synaptics-rmi4 - clear irqs before set irqs Aaron Ma
2019-02-20 16:42 ` [PATCH 2/2] Input: synaptics-rmi4 - export nosleep of f01 via sysfs Aaron Ma
2019-06-09 16:53 ` Dmitry Torokhov
2019-03-08 23:13 ` [PATCH 1/2] Input: synaptics-rmi4 - clear irqs before set irqs Christopher Heiny
2019-03-09 8:37 ` Aaron Ma
2019-03-28 6:02 ` Aaron Ma
2019-04-02 16:16 ` Christopher Heiny
2019-04-03 13:58 ` Aaron Ma
2019-06-04 2:45 ` Aaron Ma
2019-06-04 5:19 ` Christopher Heiny [this message]
2019-06-07 7:48 ` Aaron Ma
2019-06-09 16:55 ` Dmitry Torokhov
2019-06-10 16:55 ` Aaron Ma
2019-06-11 17:35 ` Dmitry Torokhov
2019-06-14 4:26 ` Aaron Ma
2019-11-19 5:34 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=580b73847333fa1866caaccc959bf8735b4f7524.camel@synaptics.com \
--to=cheiny@synaptics.com \
--cc=aaron.ma@canonical.com \
--cc=aduggan@synaptics.com \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).