From: Thara Gopinath <thara.gopinath@linaro.org>
To: Chengfeng Ye <cyeaa@connect.ust.hk>,
herbert@gondor.apana.org.au, davem@davemloft.net,
svarbanov@mm-sol.com
Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] crypto: qce: fix uaf on qce_ahash_register_one
Date: Fri, 5 Nov 2021 17:10:10 -0400 [thread overview]
Message-ID: <58122e53-b85e-5bc9-4eca-396623e62fae@linaro.org> (raw)
In-Reply-To: <20211104133831.20049-1-cyeaa@connect.ust.hk>
On 11/4/21 9:38 AM, Chengfeng Ye wrote:
> Pointer base points to sub field of tmpl, it
> is dereferenced after tmpl is freed. Fix
> this by accessing base before free tmpl.
>
> Fixes: ec8f5d8f ("crypto: qce - Qualcomm crypto engine driver")
> Signed-off-by: Chengfeng Ye <cyeaa@connect.ust.hk>
Acked-by: Thara Gopinath <thara.gopinath@linaro.org>
> ---
> drivers/crypto/qce/sha.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/qce/sha.c b/drivers/crypto/qce/sha.c
> index 8e6fcf2c21cc..59159f5e64e5 100644
> --- a/drivers/crypto/qce/sha.c
> +++ b/drivers/crypto/qce/sha.c
> @@ -498,8 +498,8 @@ static int qce_ahash_register_one(const struct qce_ahash_def *def,
>
> ret = crypto_register_ahash(alg);
> if (ret) {
> - kfree(tmpl);
> dev_err(qce->dev, "%s registration failed\n", base->cra_name);
> + kfree(tmpl);
> return ret;
> }
>
>
--
Warm Regards
Thara (She/Her/Hers)
next prev parent reply other threads:[~2021-11-05 21:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 13:38 [PATCH] crypto: qce: fix uaf on qce_ahash_register_one Chengfeng Ye
2021-11-05 21:10 ` Thara Gopinath [this message]
2021-11-20 4:30 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58122e53-b85e-5bc9-4eca-396623e62fae@linaro.org \
--to=thara.gopinath@linaro.org \
--cc=cyeaa@connect.ust.hk \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=svarbanov@mm-sol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).