From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED05CC4338F for ; Fri, 30 Jul 2021 16:05:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5A2860C3F for ; Fri, 30 Jul 2021 16:05:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229648AbhG3QF5 (ORCPT ); Fri, 30 Jul 2021 12:05:57 -0400 Received: from smtp-relay-canonical-1.canonical.com ([185.125.188.121]:38676 "EHLO smtp-relay-canonical-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229466AbhG3QFy (ORCPT ); Fri, 30 Jul 2021 12:05:54 -0400 Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPS id 45D033F24F for ; Fri, 30 Jul 2021 16:05:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1627661148; bh=ckOz90kE72EEodkfysirBp4bfPPhomkbsSq4zFCD8p4=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=ivOSwVeQ0XHeXJBn214ExMBSMaX2KvjrEqvC+7lTcxGxtfWL13XYfOQpgoFMqebyL lKFXypmXXtKLme757tve6gpoWOI7zOxyYNZgqjALJxUvxOtTabZIWt4GCV8pH9pGNr uH5TNdRyTINpmfX10QPA19OX2vYHPuTv2CtnFEes1iwLWMSsQiahHYyvamYA6K9VkG JCF73vvZFCBmbl3EWPkbfzNPMXxtMj5mOxerhiQyBn4IsPLzPQ1lDzlub4DfgPLPZr gv6YGzFsgOfDfMMAKTIXQdBY4PqKp7vH4tAPYitmmTgV5nXROYHrlFZ7jdbzpufSZT jbATtbenVqPVg== Received: by mail-ej1-f70.google.com with SMTP id n9-20020a1709063789b02905854bda39fcso3272084ejc.1 for ; Fri, 30 Jul 2021 09:05:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ckOz90kE72EEodkfysirBp4bfPPhomkbsSq4zFCD8p4=; b=Dq0ECHCTcLIuI3+mqvO2WZjFHNj8XMq/26pScolIPs513BHoaO9c7Xx31bzSHJqupG cIqHHttu90aq9uU4U2uoly3OJHeR3tRfMJXzPB1My+jx/tshGxbwDF7VdUCdT+4Nb3Po 8jhwcGqocFeFdx4nQj60pS21onPw7e9Q+4Z5wjffr2HDFIt1G85uNF4S7FaMgem0wnkM 1fPB4QFLZaeM6DFK9rjP2toysXc7AdO1kRNJ0UUa8S+oALc2xGnXpB0oLBnbTJOWY8BB cT+y5bYoDiQL3tm08/qIRofUit3vnzSPJKl16hP7uDwD9/GRparT86oJ2WCdm43wRIzA WegA== X-Gm-Message-State: AOAM531KASm6iCnJuCWX4vXrCk4RgqnH6/LdHcFGgamyYZ80Pi2J4MP4 ODjr5J7luTFIZB5ym2lXx1/QQdmSR8afCc2ulbacld3Bi/40QWe+PnwOMmk3swTqJPTTx5JCxZa cTaIP2vAUQ3X/LzDltjMhSDMRy/ykyjt6hsvMWoHpjA== X-Received: by 2002:a17:906:c0cd:: with SMTP id bn13mr3270800ejb.251.1627661145661; Fri, 30 Jul 2021 09:05:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz7c3uXOvkRzFd+EjfGwOi9GkfnP6xyPWeV21oXtz+M8LxzO4q9ZXaaXNPEO6I0wjp44bYNLA== X-Received: by 2002:a17:906:c0cd:: with SMTP id bn13mr3270781ejb.251.1627661145512; Fri, 30 Jul 2021 09:05:45 -0700 (PDT) Received: from [192.168.8.102] ([86.32.47.9]) by smtp.gmail.com with ESMTPSA id b3sm697246ejb.7.2021.07.30.09.05.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jul 2021 09:05:45 -0700 (PDT) Subject: Re: [PATCH 06/12] tty: serial: samsung: Add Exynos850 SoC data To: Sam Protsenko , Sylwester Nawrocki , Chanwoo Choi , Linus Walleij , Tomasz Figa Cc: Rob Herring , Stephen Boyd , Michael Turquette , Jiri Slaby , Greg Kroah-Hartman , Charles Keepax , Ryu Euiyoul , Tom Gall , Sumit Semwal , John Stultz , Amit Pundir , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org References: <20210730144922.29111-1-semen.protsenko@linaro.org> <20210730144922.29111-7-semen.protsenko@linaro.org> From: Krzysztof Kozlowski Message-ID: <5826bc3e-e9e8-a9bb-4541-21c1b944a60e@canonical.com> Date: Fri, 30 Jul 2021 18:05:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210730144922.29111-7-semen.protsenko@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/07/2021 16:49, Sam Protsenko wrote: > Add serial driver data for Exynos850 SoC. This driver data is basically > reusing EXYNOS_COMMON_SERIAL_DRV_DATA, which is common for all Exynos > chips, but also enables USI init, which was added in previous commit: > "tty: serial: samsung: Init USI to keep clocks running". > > Signed-off-by: Sam Protsenko > --- > drivers/tty/serial/samsung_tty.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c > index 75ccbb08df4a..d059b516a0f4 100644 > --- a/drivers/tty/serial/samsung_tty.c > +++ b/drivers/tty/serial/samsung_tty.c > @@ -2814,11 +2814,19 @@ static struct s3c24xx_serial_drv_data exynos5433_serial_drv_data = { > .fifosize = { 64, 256, 16, 256 }, > }; > > +static struct s3c24xx_serial_drv_data exynos850_serial_drv_data = { > + EXYNOS_COMMON_SERIAL_DRV_DATA_USI(1), > + .fifosize = { 0, }, This does not look correct. You rely on samsung,uart-fifosize property but it is optional. Best regards, Krzysztof