From: Dmitry Safonov <dima@arista.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 2/2] serial/sysrq: Add MAGIC_SYSRQ_SERIAL_SEQUENCE
Date: Tue, 3 Mar 2020 18:06:53 +0000 [thread overview]
Message-ID: <58272ab2-a149-8b7a-d109-1d7b9564c167@arista.com> (raw)
In-Reply-To: <202003031201.WdZ9GaGO%lkp@intel.com>
On 3/3/20 4:31 AM, kbuild test robot wrote:
> Hi Dmitry,
[..]
> New smatch warnings:
> drivers/tty/serial/serial_core.c:3123 uart_try_toggle_sysrq() warn: unsigned '++port->sysrq_seq' is never less than zero.
False-positive as just a few lines above:
: if (ARRAY_SIZE(sysrq_toggle_seq) <= 1)
: return false;
I hope it's fine just to ignore this rather than complicate anyhow code
to suppress the warning.
Thanks,
Dmitry
next prev parent reply other threads:[~2020-03-03 18:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 17:51 [PATCHv3 0/2] serial/sysrq: Add MAGIC_SYSRQ_SERIAL_SEQUENCE Dmitry Safonov
2020-03-02 17:51 ` [PATCHv3 1/2] sysctl/sysrq: Remove __sysrq_enabled copy Dmitry Safonov
2020-04-01 12:22 ` Michael Ellerman
2020-04-01 14:41 ` Dmitry Safonov
2020-03-02 17:51 ` [PATCHv3 2/2] serial/sysrq: Add MAGIC_SYSRQ_SERIAL_SEQUENCE Dmitry Safonov
2020-03-03 4:31 ` kbuild test robot
2020-03-03 18:06 ` Dmitry Safonov [this message]
2020-03-06 12:55 ` Greg Kroah-Hartman
2020-03-06 14:50 ` Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58272ab2-a149-8b7a-d109-1d7b9564c167@arista.com \
--to=dima@arista.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).