From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964960AbcKXSzf (ORCPT ); Thu, 24 Nov 2016 13:55:35 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:49900 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941141AbcKXSzc (ORCPT ); Thu, 24 Nov 2016 13:55:32 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 500776151D Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=timur@codeaurora.org Subject: Re: [PATCH net v2 5/5] net: qcom/emac: fix of_node and phydev leaks To: Johan Hovold , "David S. Miller" Cc: Florian Fainelli , Madalin Bucur , Andrew Lunn , Vivien Didelot , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1480011691-13278-1-git-send-email-johan@kernel.org> <1480011691-13278-6-git-send-email-johan@kernel.org> From: Timur Tabi Message-ID: <5837379C.4080400@codeaurora.org> Date: Thu, 24 Nov 2016 12:55:24 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:43.0) Gecko/20100101 Firefox/43.0 SeaMonkey/2.40 MIME-Version: 1.0 In-Reply-To: <1480011691-13278-6-git-send-email-johan@kernel.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Johan Hovold wrote: > Make sure to drop the reference taken by of_phy_find_device() during > probe on probe errors and on driver unbind. > > Also drop the of_node reference taken by of_parse_phandle() in the same > path. > > Fixes: b9b17debc69d ("net: emac: emac gigabit ethernet controller driver") > Signed-off-by: Johan Hovold When I first wrote this code, I had a lot of trouble getting the PHY to re-probe when the driver was unloaded and reloaded, and it was because of some odd problems with get/put of of_nodes. Since I know that you didn't test this driver on real hardware, I have to test these patches myself before I can ACK them. -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation.