From: zhong jiang <zhongjiang@huawei.com>
To: <catalin.marinas@arm.com>, <will.deacon@arm.com>,
<rrichter@cavium.com>, <mark.rutland@arm.com>, <arnd@arndb.de>,
<ard.biesheuvel@linaro.org>, <robh+dt@kernel.org>,
<dwoods@ezchip.com>, <jeremy.linton@arm.com>
Cc: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH 2/2] arm64: make WANT_HUGE_PMD_SHARE depends on HUGETLB_PAGE
Date: Fri, 16 Dec 2016 17:10:05 +0800 [thread overview]
Message-ID: <5853AF6D.20305@huawei.com> (raw)
In-Reply-To: <1481725151-20549-3-git-send-email-zhongjiang@huawei.com>
On 2016/12/14 22:19, zhongjiang wrote:
> From: zhong jiang <zhongjiang@huawei.com>
>
> when HUGETLB_PAGE is disable, WANT_HUGE_PMD_SHARE contains the
> fuctions should not be use. therefore, we add the dependency.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> arch/arm64/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 969ef88..694ca73 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -640,6 +640,7 @@ config SYS_SUPPORTS_HUGETLBFS
>
> config ARCH_WANT_HUGE_PMD_SHARE
> def_bool y if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36)
> + depends on HUGETLB_PAGE
>
> config ARCH_HAS_CACHE_LINE_SIZE
> def_bool y
Hi,
I still think it is a issue. Perhaps above changelog is unclear. Further explain is as follows.
when hugetlb_pages is disable and arch_want_huge_pmd_share is enable, we maybe call
huge_pmd_sahre in hugetlbpage.c, but the function actually is not definition as it is not
exported. is it right ??
Thanks
zhongjiang
next prev parent reply other threads:[~2016-12-16 9:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 14:19 [RESEND PATCH 0/2] fix some trivial bug involving the contiguous bit zhongjiang
2016-12-14 14:19 ` [RESEND PATCH 1/2] arm64: change from CONT_PMD_SHIFT to CONT_PTE_SHIFT zhongjiang
2016-12-14 14:45 ` Ard Biesheuvel
2016-12-15 2:59 ` zhong jiang
2017-01-03 12:31 ` Catalin Marinas
2016-12-14 14:19 ` [RESEND PATCH 2/2] arm64: make WANT_HUGE_PMD_SHARE depends on HUGETLB_PAGE zhongjiang
2016-12-16 9:10 ` zhong jiang [this message]
2016-12-16 12:35 ` Will Deacon
2016-12-16 12:56 ` zhong jiang
2016-12-16 14:08 ` zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5853AF6D.20305@huawei.com \
--to=zhongjiang@huawei.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=dwoods@ezchip.com \
--cc=jeremy.linton@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=rrichter@cavium.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).