From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752938AbcLSGvl (ORCPT ); Mon, 19 Dec 2016 01:51:41 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:55093 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750908AbcLSGvj (ORCPT ); Mon, 19 Dec 2016 01:51:39 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee61b-f79d86d00000197e-6b-5857837255d3 Content-transfer-encoding: 8BIT Message-id: <58578372.8000909@samsung.com> Date: Mon, 19 Dec 2016 15:51:30 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Hans de Goede , MyungJoo Ham Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/8] extcon: axp288: Remove unnecessary irq?_en register writes References: <20161219001313.13402-1-hdegoede@redhat.com> <20161219001313.13402-7-hdegoede@redhat.com> In-reply-to: <20161219001313.13402-7-hdegoede@redhat.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrAIsWRmVeSWpSXmKPExsVy+t9jAd2i5vAIg417JC3eHJ/OZHF51xw2 i9uNK9gcmD3e77vK5tG3ZRWjx+dNcgHMUW42GamJKalFCql5yfkpmXnptkqhIW66FkoKeYm5 qbZKEbq+IUFKCmWJOaVAnpEBGnBwDnAPVtK3S3DL2DbhCFPBQaGKnlkHWBsYf/B1MXJySAiY SLz985IFwhaTuHBvPVsXIxeHkMBSRonzi++wgiR4BQQlfky+B1TEwcEsIC9x5FI2SJhZQF1i 0rxFzBD1DxglNk64wwZSwyugJXFhii9IDYuAqsTDRafYQGw2oPD+FzfAbH4BRYmrPx4zgpSL CkRIdJ+oBAmLCARI/DzVzw4xXkHi171NYBcIC4RKfOqfywKxajejxI7vb5hBEpwClhI9O26y TGAUnIXk0lkIl85CcukCRuZVjBKpBckFxUnpuUZ5qeV6xYm5xaV56XrJ+bmbGMGx80x6B+Ph Xe6HGAU4GJV4eCdwh0cIsSaWFVfmHmKU4GBWEuEtbwAK8aYkVlalFuXHF5XmpBYfYjQF+nUi s5Rocj4wrvNK4g1NzE3MjQ0szC0tTYyUxHkbZz8LFxJITyxJzU5NLUgtgulj4uCUamBcyb7I YPE3/r8SLSqu8Zkz1oa+Nv/I87bXLL9x+fF1HgaZThNZNN8KMcrM/yS3Vv+4wO8dMxdGHX5e KOCo++mdybkX1d/7spWeb7xi9qD/XrGHzsrdutn+ewxZ7G12/Xy14/f+niIm5adLuxMV/DZq zLvIu8G8oUp3zdIA8QplnsWvtihriV5RYinOSDTUYi4qTgQA/Lxw5LMCAAA= X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hans, On 2016년 12월 19일 09:13, Hans de Goede wrote: > Setting the irq_enable bits is taken care of by the irq chip when we > request the irqs and the driver should not be meddling with the > irq?_en registers itself. > > Signed-off-by: Hans de Goede > --- > drivers/extcon/extcon-axp288.c | 19 +++---------------- > 1 file changed, 3 insertions(+), 16 deletions(-) > > diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c > index 7aec413..a27ee68 100644 > --- a/drivers/extcon/extcon-axp288.c > +++ b/drivers/extcon/extcon-axp288.c > @@ -70,12 +70,6 @@ > #define DET_STAT_CDP 2 > #define DET_STAT_DCP 3 > > -/* IRQ enable-1 register */ > -#define PWRSRC_IRQ_CFG_MASK (BIT(4)|BIT(3)|BIT(2)) > - > -/* IRQ enable-6 register */ > -#define BC12_IRQ_CFG_MASK BIT(1) > - > enum axp288_extcon_reg { > AXP288_PS_STAT_REG = 0x00, > AXP288_PS_BOOT_REASON_REG = 0x02, > @@ -83,8 +77,6 @@ enum axp288_extcon_reg { > AXP288_BC_VBUS_CNTL_REG = 0x2d, > AXP288_BC_USB_STAT_REG = 0x2e, > AXP288_BC_DET_STAT_REG = 0x2f, > - AXP288_PWRSRC_IRQ_CFG_REG = 0x40, > - AXP288_BC12_IRQ_CFG_REG = 0x45, > }; > > enum axp288_mux_select { > @@ -242,15 +234,10 @@ static irqreturn_t axp288_extcon_isr(int irq, void *data) > return IRQ_HANDLED; > } > > -static void axp288_extcon_enable_irq(struct axp288_extcon_info *info) > +static void axp288_extcon_enable(struct axp288_extcon_info *info) > { > - /* Unmask VBUS interrupt */ > - regmap_write(info->regmap, AXP288_PWRSRC_IRQ_CFG_REG, > - PWRSRC_IRQ_CFG_MASK); > regmap_update_bits(info->regmap, AXP288_BC_GLOBAL_REG, > BC_GLOBAL_RUN, 0); > - /* Unmask the BC1.2 complete interrupts */ > - regmap_write(info->regmap, AXP288_BC12_IRQ_CFG_REG, BC12_IRQ_CFG_MASK); > /* Enable the charger detection logic */ > regmap_update_bits(info->regmap, AXP288_BC_GLOBAL_REG, > BC_GLOBAL_RUN, BC_GLOBAL_RUN); > @@ -327,8 +314,8 @@ static int axp288_extcon_probe(struct platform_device *pdev) > } > } > > - /* Enable interrupts */ > - axp288_extcon_enable_irq(info); > + /* Start charger cable type detection */ > + axp288_extcon_enable(info); > > return 0; > } > Looks good to me. Acked-by: Chanwoo Choi -- Regards, Chanwoo Choi