From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754014AbcLSGyJ (ORCPT ); Mon, 19 Dec 2016 01:54:09 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:42170 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750908AbcLSGyI (ORCPT ); Mon, 19 Dec 2016 01:54:08 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee61a-f79bd6d000000fc6-ea-5857840e2eaf Content-transfer-encoding: 8BIT Message-id: <5857840E.6000208@samsung.com> Date: Mon, 19 Dec 2016 15:54:06 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Hans de Goede , MyungJoo Ham Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/8] extcon: axp288: Remove usb_phy notification code References: <20161219001313.13402-1-hdegoede@redhat.com> <20161219001313.13402-2-hdegoede@redhat.com> In-reply-to: <20161219001313.13402-2-hdegoede@redhat.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrAIsWRmVeSWpSXmKPExsVy+t9jQV2+lvAIgxlnLS3eHJ/OZHF51xw2 i9uNK9gcmD3e77vK5tG3ZRWjx+dNcgHMUW42GamJKalFCql5yfkpmXnptkqhIW66FkoKeYm5 qbZKEbq+IUFKCmWJOaVAnpEBGnBwDnAPVtK3S3DLaJ19lbHgvFDFoymyDYw9/F2MnBwSAiYS DWduMEHYYhIX7q1n62Lk4hASmMUoMWfBWzaQBK+AoMSPyfdYuhg5OJgF5CWOXMoGCTMLqEtM mreIGaL+AaNE+8KnrBD1WhLvVl1lAbFZBFQlnmw9DTaHDSi+/8UNMJtfQFHi6o/HjCAzRQUi JLpPVIKERQQCJH6e6meHmK8g8eveJrCRwgKeEreWb4a6bTejxNqFC5hBEpwClhJre9cyTmAU nIXk1FkIp85CcuoCRuZVjBKpBckFxUnpuYZ5qeV6xYm5xaV56XrJ+bmbGMGx80xqB+PBXe6H GAU4GJV4eAveh0UIsSaWFVfmHmKU4GBWEuEtbwiPEOJNSaysSi3Kjy8qzUktPsRoCvTrRGYp 0eR8YFznlcQbmpibmBsbWJhbWpoYKYnzNs5+Fi4kkJ5YkpqdmlqQWgTTx8TBKdXAeOWPnoPj X85d8wLzPh7rbj58OOicT3PZRMkJiuxy2Ytv2AUZ/vkjdLyvaf0BgbxnR1wyS2sz7pVOYp6v aFuySebXKsnGORcVPV+uP8K5ekG9Qcc0gWQRXe6/Cgw7HhmF8ZWsO+MuUuPnqsX99/x8p+yN USYqL8sfn+JYPSP19cVpFzsdZe8vV2Ipzkg01GIuKk4EANfUL2KzAgAA X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hans, On 2016년 12월 19일 09:13, Hans de Goede wrote: > The usb_phy based intel-usb-phy code never got merged into the > mainline kernel, so the devm_usb_get_phy() call will always fail, > blocking the driver from loading. > > Since new drivers should use the generic-phy framework, not the > old-style usb_phy stuff, keeping this around is not useful. > > Therefor this patch removes the usb_phy notification bits, which together > with the patch to remove the platform_data dependency, makes this driver > actually successfully probe on systems with an axp288 pmic. > > Signed-off-by: Hans de Goede > --- > drivers/extcon/extcon-axp288.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c > index a84fab8..3d5e84e 100644 > --- a/drivers/extcon/extcon-axp288.c > +++ b/drivers/extcon/extcon-axp288.c > @@ -21,7 +21,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -116,7 +115,6 @@ struct axp288_extcon_info { > int irq[EXTCON_IRQ_END]; > struct extcon_dev *edev; > struct notifier_block extcon_nb; > - struct usb_phy *otg; > }; > > /* Power up/down reason string array */ > @@ -220,9 +218,6 @@ static int axp288_handle_chrg_det_event(struct axp288_extcon_info *info) > gpiod_set_value(info->gpio_mux_cntl, > vbus_attach ? EXTCON_GPIO_MUX_SEL_SOC > : EXTCON_GPIO_MUX_SEL_PMIC); > - > - atomic_notifier_call_chain(&info->otg->notifier, > - vbus_attach ? USB_EVENT_VBUS : USB_EVENT_NONE, NULL); > } > > if (notify_charger) > @@ -303,13 +298,6 @@ static int axp288_extcon_probe(struct platform_device *pdev) > return ret; > } > > - /* Get otg transceiver phy */ > - info->otg = devm_usb_get_phy(&pdev->dev, USB_PHY_TYPE_USB2); > - if (IS_ERR(info->otg)) { > - dev_err(&pdev->dev, "failed to get otg transceiver\n"); > - return PTR_ERR(info->otg); > - } > - > /* Set up gpio control for USB Mux */ > if (info->gpio_mux_cntl) { > gpio = desc_to_gpio(info->gpio_mux_cntl); > Looks good to me. Acked-by: Chanwoo Choi -- Regards, Chanwoo Choi