From: Dongpo Li <lidongpo@hisilicon.com>
To: Rob Herring <robh@kernel.org>
Cc: David Miller <davem@davemloft.net>,
Mark Rutland <mark.rutland@arm.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Russell King <linux@armlinux.org.uk>,
Zhangfei Gao <zhangfei.gao@linaro.org>,
Yisen Zhuang <yisen.zhuang@huawei.com>, <salil.mehta@huawei.com>,
Arnd Bergmann <arnd@arndb.de>, Andrew Lunn <andrew@lunn.ch>,
Jiancheng Xue <xuejiancheng@hisilicon.com>,
<benjamin.chenhao@hisilicon.com>, <caizhiyong@hisilicon.com>,
netdev <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/4] net: hix5hd2_gmac: add generic compatible string
Date: Tue, 20 Dec 2016 09:35:36 +0800 [thread overview]
Message-ID: <58588AE8.4040901@hisilicon.com> (raw)
In-Reply-To: <CAL_Jsq+Su84DonQbh2KZ2o8JQ0Mqarag60Oq=Dby3y8Doyozxg@mail.gmail.com>
On 2016/12/20 0:04, Rob Herring wrote:
> On Mon, Dec 19, 2016 at 2:14 AM, Dongpo Li <lidongpo@hisilicon.com> wrote:
>> Hi Rob and David,
>>
>> On 2016/12/12 22:21, Rob Herring wrote:
>>> On Mon, Dec 12, 2016 at 5:16 AM, Dongpo Li <lidongpo@hisilicon.com> wrote:
>>>> Hi Rob,
>>>>
>>>> On 2016/12/10 6:35, Rob Herring wrote:
>>>>> On Mon, Dec 05, 2016 at 09:27:58PM +0800, Dongpo Li wrote:
>
> [...]
>
>>>>>> @@ -20,7 +25,7 @@ Required properties:
>>>>>>
>>>>>> Example:
>>>>>> gmac0: ethernet@f9840000 {
>>>>>> - compatible = "hisilicon,hix5hd2-gmac";
>>>>>> + compatible = "hisilicon,hix5hd2-gemac", "hisilicon,hisi-gemac-v1";
>>>>>
>>>>> You can't just change compatible strings.
>>>>>
>>>> Okay, maybe I should name all the compatible string with the suffix "-gmac" instead of
>>>> "-gemac". This can keep the compatible strings with the same suffix. Is this okay?
>>>> Can I just add the generic compatible string without changing the SoCs compatible string?
>>>> Like following:
>>>> gmac0: ethernet@f9840000 {
>>>> - compatible = "hisilicon,hix5hd2-gmac";
>>>> + compatible = "hisilicon,hix5hd2-gmac", "hisilicon,hisi-gmac-v1";
>>>
>>> Yes, this is fine.
>>
>> As the patch series have been applied to net-next branch,
>> in which way should I commit this compatible fix?
>> Should I send a new patch fixing this compatible string error with "Fixes: xxx"?
>> Looking forward to your reply!
>
> Yes to both.
Okay, thanks for your reply!
I will send the fix patch series as soon as possible.
Regards,
Dongpo
.
next prev parent reply other threads:[~2016-12-20 1:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 13:27 [PATCH v2 0/4] net: hix5hd2_gmac: add tx sg feature and reset/clock control signals Dongpo Li
2016-12-05 13:27 ` [PATCH v2 1/4] net: hix5hd2_gmac: add generic compatible string Dongpo Li
2016-12-09 22:35 ` Rob Herring
2016-12-12 11:16 ` Dongpo Li
2016-12-12 14:21 ` Rob Herring
2016-12-13 2:02 ` Dongpo Li
2016-12-19 8:14 ` Dongpo Li
2016-12-19 16:04 ` Rob Herring
2016-12-20 1:35 ` Dongpo Li [this message]
2016-12-05 13:27 ` [PATCH v2 2/4] net: hix5hd2_gmac: add tx scatter-gather feature Dongpo Li
2016-12-05 13:28 ` [PATCH v2 3/4] net: hix5hd2_gmac: add reset control and clock signals Dongpo Li
2016-12-05 13:28 ` [PATCH v2 4/4] ARM: dts: hix5hd2: add gmac generic compatible and clock names Dongpo Li
2016-12-06 15:21 ` [PATCH v2 0/4] net: hix5hd2_gmac: add tx sg feature and reset/clock control signals David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58588AE8.4040901@hisilicon.com \
--to=lidongpo@hisilicon.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=benjamin.chenhao@hisilicon.com \
--cc=caizhiyong@hisilicon.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
--cc=salil.mehta@huawei.com \
--cc=sboyd@codeaurora.org \
--cc=xuejiancheng@hisilicon.com \
--cc=yisen.zhuang@huawei.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).