From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755975AbcLUHUm (ORCPT ); Wed, 21 Dec 2016 02:20:42 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:50501 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754262AbcLUHUh (ORCPT ); Wed, 21 Dec 2016 02:20:37 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee61a-f79bd6d000000fc6-3b-585a2d415cda Content-transfer-encoding: 8BIT Message-id: <585A2D40.9000606@samsung.com> Date: Wed, 21 Dec 2016 16:20:32 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Baolin Wang , myungjoo.ham@samsung.com, wens@csie.org, kishon@ti.com, heiko@sntech.de Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linaro-kernel@lists.linaro.org, broonie@kernel.org, neilb@suse.com Subject: Re: [PATCH 1/3] extcon: Add documentation for EXTCON_CHG_USB_* and EXTCON_USB_* References: <7b9836ce2ca34118a2acd1ea113605a5f13b4439.1482300213.git.baolin.wang@linaro.org> In-reply-to: <7b9836ce2ca34118a2acd1ea113605a5f13b4439.1482300213.git.baolin.wang@linaro.org> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBIsWRmVeSWpSXmKPExsVy+t9jQV1H3agIg1ebBSw+NVxhtpj68Amb xf9Hr1ktLjztYbN4f+gZs8Wmx9dYLS7vmsNm8enBf2aL240rgKyNsRY/D51ncuD22PBoNavH plWdbB53ru1h89i8pN7j9r/HzB59W1Yxemy/No/ZY/2Wqywex29sZ/L4vEkugCvKzSYjNTEl tUghNS85PyUzL91WKTTETddCSSEvMTfVVilC1zckSEmhLDGnFMgzMkADDs4B7sFK+nYJbhkr zi1nKzjOW/Fp9yr2BsZm7i5GDg4JAROJxksxXYycQKaYxIV769m6GLk4hARmMUrsfb+UESTB KyAo8WPyPRaQemYBeYkjl7JBwswC6hKT5i1ihqh/wCjx99oVJoh6LYmJjS/ZQOpZBFQlVt4W BgmzAYX3v7jBBmLzCyhKXP3xmBGkRFQgQqL7RCVIWESgWGLCocWsICOZBTYxSjzbNQnsBGGB KIkLv/azgNhCIIkTD6tBbE6BeIm3TXsYJzAKzkJy6SyES2chuXQBI/MqRonUguSC4qT0XMO8 1HK94sTc4tK8dL3k/NxNjOBYfia1g/HgLvdDjAIcjEo8vDusIyOEWBPLiitzDzFKcDArifBu 1I6KEOJNSaysSi3Kjy8qzUktPsRoCvTqRGYp0eR8YJrJK4k3NDE3MTc2sDC3tDQxUhLnbZz9 LFxIID2xJDU7NbUgtQimj4mDU6qBcdUJ1WsV/lvX2Oq9P7E+nkVWa+ml5O3b4nO2nvZYuP/U 24aWrV369m1SN5+udz6/z9qtfMaJL7HbQ3etnbZe0UL2OmsiXyJPuH5pvIG8D++MWxpm63zk jhv5uCfFvZnN7NouGLI4Yebe/EUnP0ZO50iSnXyGte3tk2NLDDZ7SpxYrHkz/c5cYSWW4oxE Qy3mouJEAKjHoYv7AgAA X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2016년 12월 21일 15:10, Baolin Wang wrote: > Current there is both "EXTCON_USB" and "EXTCON_CHG_USB_SDP" which > both seem to suggest a standard downstream port. But there is no > documentation describing how these relate. > > Thus add documentation to describe EXTCON_CHG_USB_SDP should always > appear together with EXTCON_USB, and EXTCON_CHG_USB_ACA would normally > appear with EXTCON_USB_HOST. > > Signed-off-by: Baolin Wang > --- > include/linux/extcon.h | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/include/linux/extcon.h b/include/linux/extcon.h > index b871c0c..6498b05 100644 > --- a/include/linux/extcon.h > +++ b/include/linux/extcon.h > @@ -46,7 +46,14 @@ > #define EXTCON_USB 1 > #define EXTCON_USB_HOST 2 > > -/* Charging external connector */ > +/* > + * Charging external connector > + * > + * When one SDP charger connector was reported, we should also report > + * the USB connector, which means EXTCON_CHG_USB_SDP should always > + * appear together with EXTCON_USB. The same as ACA charger connector, > + * EXTCON_CHG_USB_ACA should always appear with EXTCON_USB_HOST. > + */ Looks good to me. But, you use the different word for ACA as following: I think that 'would normally' is proper in descritpion. - commit msg : EXTCON_CHG_USB_ACA would normally appear with EXTCON_USB_HOST. - description: EXTCON_CHG_USB_ACA should always appear with EXTCON_USB_HOST. > #define EXTCON_CHG_USB_SDP 5 /* Standard Downstream Port */ > #define EXTCON_CHG_USB_DCP 6 /* Dedicated Charging Port */ > #define EXTCON_CHG_USB_CDP 7 /* Charging Downstream Port */ > -- Regards, Chanwoo Choi