From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754485AbcLUH3m (ORCPT ); Wed, 21 Dec 2016 02:29:42 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:54938 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751098AbcLUH3k (ORCPT ); Wed, 21 Dec 2016 02:29:40 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee61a-f79bd6d000000fc6-40-585a2f612aaa Content-transfer-encoding: 8BIT Message-id: <585A2F61.20403@samsung.com> Date: Wed, 21 Dec 2016 16:29:37 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Baolin Wang , myungjoo.ham@samsung.com, wens@csie.org, kishon@ti.com, heiko@sntech.de Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linaro-kernel@lists.linaro.org, broonie@kernel.org, neilb@suse.com Subject: Re: [PATCH 3/3] phy: rockchip-inno-usb2: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set References: <7b9836ce2ca34118a2acd1ea113605a5f13b4439.1482300213.git.baolin.wang@linaro.org> <767c3dfccde4807e3645951d4aeebca0ab5cc5e4.1482300213.git.baolin.wang@linaro.org> In-reply-to: <767c3dfccde4807e3645951d4aeebca0ab5cc5e4.1482300213.git.baolin.wang@linaro.org> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrFIsWRmVeSWpSXmKPExsVy+t9jAd1E/agIg/67qhafGq4wW0x9+ITN 4v+j16wWF572sFm8P/SM2WLT42usFpd3zWGz+PTgP7PF7cYVQNbGWIufh84zOXB7bHi0mtVj 06pONo871/aweWxeUu9x+99jZo++LasYPbZfm8fssX7LVRaP4ze2M3l83iQXwBXlZpORmpiS WqSQmpecn5KZl26rFBripmuhpJCXmJtqqxSh6xsSpKRQlphTCuQZGaABB+cA92AlfbsEt4zd 62exFMzgrVj4fBVzA+Mjri5GTg4JAROJowfms0LYYhIX7q1n62Lk4hASWMooMffEa2aQBK+A oMSPyfdYuhg5OJgF5CWOXMoGCTMLqEtMmreIGaL+AaPEph+LWSDqNSReTehmB7FZBFQl2o/1 sIHYbAJaEvtf3ACz+QUUJa7+eMwIMlNUIEKi+0QlSFhEoFhiwqHFrCAzmQU2MUo82zWJESQh LJAkseLCbajjWpkkPrz+BtbMKRAv8aMjaQKj4Cwkp85COHUWklMXMDKvYpRILUguKE5KzzXM Sy3XK07MLS7NS9dLzs/dxAiO52dSOxgP7nI/xCjAwajEw7vDOjJCiDWxrLgy9xCjBAezkgjv Ru2oCCHelMTKqtSi/Pii0pzU4kOMpkC/TmSWEk3OB6aavJJ4QxNzE3NjAwtzS0sTIyVx3sbZ z8KFBNITS1KzU1MLUotg+pg4OKUaGJlKHkd/umP+Rr7B53rT6klMd677XXxrMsXu+z7D4FuR TxdKV5Z0cvuqVUYl77af9v36N8XOU4zF7L1brYwSpyacmnhB5lTjztst68NXuKX4djCI8esZ r5n5/fgjuxIL8yixZx+UZCdxWOR+s7nsHOd3yeLY2hQVea1Ah12aXtlXTS75eS3MUmIpzkg0 1GIuKk4EAOK5la39AgAA X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2016년 12월 21일 15:10, Baolin Wang wrote: > According to the documentation, we should set the EXTCON_USB when > one SDP charger connector was reported. > > Signed-off-by: Baolin Wang > --- > drivers/phy/phy-rockchip-inno-usb2.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/phy/phy-rockchip-inno-usb2.c b/drivers/phy/phy-rockchip-inno-usb2.c > index 2f99ec9..71fbe0f 100644 > --- a/drivers/phy/phy-rockchip-inno-usb2.c > +++ b/drivers/phy/phy-rockchip-inno-usb2.c > @@ -595,9 +595,14 @@ static void rockchip_usb2phy_otg_sm_work(struct work_struct *work) > if (rport->vbus_attached != vbus_attach) { > rport->vbus_attached = vbus_attach; > > - if (notify_charger && rphy->edev) > + if (notify_charger && rphy->edev) { > extcon_set_cable_state_(rphy->edev, > cable, vbus_attach); > + if (cable == EXTCON_CHG_USB_SDP) > + extcon_set_cable_state_(rphy->edev, > + EXTCON_USB, > + vbus_attach); > + } > } > break; > case OTG_STATE_B_PERIPHERAL: > Looks good to me. But I prefer to use the 'extcon_set_state_sync' intead of extcon_set_cable_state_(). Reviewed-by: Chanwoo Choi I sent the patches[1] for extcon API to alter the deprecated API. If you possible, I'd like you to alter the extcon API instead of deprecated API. [1] https://patchwork.kernel.org/patch/9453645/ - extcon_set_cable_state_() -> extcon_set_state_sync() - extcon_get_cable_state_() -> extcon_get_state() - Use devm_extcon_register_notifier() instead of extcon_register_notifier(). -- Regards, Chanwoo Choi