From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934275AbcLUH6R (ORCPT ); Wed, 21 Dec 2016 02:58:17 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:39203 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751537AbcLUH6Q (ORCPT ); Wed, 21 Dec 2016 02:58:16 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee61a-f79bd6d000000fc6-d2-585a3616decc Content-transfer-encoding: 8BIT Message-id: <585A3616.4050009@samsung.com> Date: Wed, 21 Dec 2016 16:58:14 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Baolin Wang Cc: myungjoo.ham@samsung.com, Chen-Yu Tsai , Kishon , =?UTF-8?B?SGVpa28gU3TDvGJuZXI=?= , LKML , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Linaro Kernel Mailman List , Mark Brown , NeilBrown Subject: Re: [PATCH 1/3] extcon: Add documentation for EXTCON_CHG_USB_* and EXTCON_USB_* References: <7b9836ce2ca34118a2acd1ea113605a5f13b4439.1482300213.git.baolin.wang@linaro.org> <585A2D40.9000606@samsung.com> In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJIsWRmVeSWpSXmKPExsVy+t9jQV0xs6gIg93rZC0+NVxhtpj68Amb xf9Hr1ktLjztYbN4f+gZs8Wmx9dYLS7vmsNm8enBf2aL240rgKyNsRY/D51ncuD22PBoNavH plWdbB53ru1h89i8pN7j9r/HzB59W1Yxemy/No/ZY/2Wqywex29sZ/L4vEkugCvKzSYjNTEl tUghNS85PyUzL91WKTTETddCSSEvMTfVVilC1zckSEmhLDGnFMgzMkADDs4B7sFK+nYJbhln Ji1jK3jKWzHjwTfWBsYO7i5GTg4JAROJ/ZcuM0LYYhIX7q1n62Lk4hASmMUoceTzUzaQBK+A oMSPyfdYuhg5OJgF5CWOXMqGMNUlpkzJhSh/wCgx4/dORohyLYmZ/avBbBYBVYnXnQdYQGw2 oPj+FzfARvILKEpc/fGYEWSOqECERPeJSpCwiICGxNoTO1lAZjIL/GSSOLn1GVi9sECUxIVf +1mgbmOS2NC7C2wBp0CwxOLWZywTGAVnITl1FsKpsxBOXcDIvIpRIrUguaA4KT3XMC+1XK84 Mbe4NC9dLzk/dxMjOJqfSe1gPLjL/RCjAAejEg/vDuvICCHWxLLiytxDjBIczEoivBu1oyKE eFMSK6tSi/Lji0pzUosPMZoC/TqRWUo0OR+YaPJK4g1NzE3MjQ0szC0tTYyUxHkbZz8LFxJI TyxJzU5NLUgtgulj4uCUamCc8TjgxzZPh/DvX9xVatrnia+KN4xw5g/QOflR+WtGUdwpLp6l rw7EXWb7t2XB188sixO8cx8VXOvae3uB9pmHJ1j6pIxkjKLtDLvv72XzV9bvO1+xZeE2jptC V/7Pet8leeCyp+GyKZK16zd8SFMwYdjYYtTnL/p51dncSu2TQYtDJyVEiB5RYinOSDTUYi4q TgQA+hvPoPwCAAA= X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2016년 12월 21일 16:53, Baolin Wang wrote: > Hi, > > On 21 December 2016 at 15:20, Chanwoo Choi wrote: >> Hi, >> >> On 2016년 12월 21일 15:10, Baolin Wang wrote: >>> Current there is both "EXTCON_USB" and "EXTCON_CHG_USB_SDP" which >>> both seem to suggest a standard downstream port. But there is no >>> documentation describing how these relate. >>> >>> Thus add documentation to describe EXTCON_CHG_USB_SDP should always >>> appear together with EXTCON_USB, and EXTCON_CHG_USB_ACA would normally >>> appear with EXTCON_USB_HOST. >>> >>> Signed-off-by: Baolin Wang >>> --- >>> include/linux/extcon.h | 9 ++++++++- >>> 1 file changed, 8 insertions(+), 1 deletion(-) >>> >>> diff --git a/include/linux/extcon.h b/include/linux/extcon.h >>> index b871c0c..6498b05 100644 >>> --- a/include/linux/extcon.h >>> +++ b/include/linux/extcon.h >>> @@ -46,7 +46,14 @@ >>> #define EXTCON_USB 1 >>> #define EXTCON_USB_HOST 2 >>> >>> -/* Charging external connector */ >>> +/* >>> + * Charging external connector >>> + * >>> + * When one SDP charger connector was reported, we should also report >>> + * the USB connector, which means EXTCON_CHG_USB_SDP should always >>> + * appear together with EXTCON_USB. The same as ACA charger connector, >>> + * EXTCON_CHG_USB_ACA should always appear with EXTCON_USB_HOST. >>> + */ >> >> Looks good to me. >> But, you use the different word for ACA as following: >> I think that 'would normally' is proper in descritpion. > > Okay, I will change to 'would normally' in next version patch. Thanks. Don't need to send next patch. I modify it and apply it. Thanks. -- Regards, Chanwoo Choi